Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed sip import blocks fallback to PySide #2650

Merged
merged 1 commit into from
Aug 30, 2015

Conversation

techtonik
Copy link
Contributor

Fixes #2649

@ccordoba12 ccordoba12 changed the title spyderlib.qt: Failed sip import blocks fallback to PySide (fix #2649) spyderlib.qt: Failed sip import blocks fallback to PySide Aug 27, 2015
@ccordoba12
Copy link
Member

I'm going to merge this but I'm not going to do a new 2.3 release in a couple of months.

@ccordoba12 ccordoba12 modified the milestone: v3.0 Aug 27, 2015
@ccordoba12
Copy link
Member

Probably a couple of weeks, given issue #2652.

@ccordoba12 ccordoba12 added this to the v2.3.7 milestone Aug 27, 2015
@ccordoba12 ccordoba12 changed the title spyderlib.qt: Failed sip import blocks fallback to PySide Failed sip import blocks fallback to PySide Aug 27, 2015
@goanpeca
Copy link
Member

LGTM 👍

@techtonik
Copy link
Contributor Author

Thanks for review. JFYI, I don't have access to merge it. And it should be backported to master too.

@ccordoba12
Copy link
Member

@techtonik, don't worry, I'll forward port it to master. Thanks for this, by the way :-)

ccordoba12 added a commit that referenced this pull request Aug 30, 2015
Failed sip import blocks fallback to PySide
@ccordoba12 ccordoba12 merged commit d3801ce into spyder-ide:2.3 Aug 30, 2015
@techtonik techtonik deleted the patch-2 branch August 30, 2015 16:58
@techtonik
Copy link
Contributor Author

Awesome! While you are at it, can you also merge spyder-ide/docrepr#7 - I have an interesting follow-up to it. =)

@ccordoba12
Copy link
Member

Ok, I'll do it in a couple of minutes :-)

@techtonik
Copy link
Contributor Author

@ccordoba12 here is it - spyder-ide/docrepr#8 - take a look. =)

@ArthurZ
Copy link

ArthurZ commented Oct 30, 2015

Anaconda Launcher reports I have ver 2.3.7 installed and when I start it I am seeing an error:
Please check Spyder installation requirements: PyQt4 4.6+ (or PySide 1.2.0+) is required.
I am on Windows 7.
Starting Spyder from the Start menu makes it run, but it is ver. 2.3.6
Note: I attempted to conda update -all and was getting linking errors I ignored.

@techtonik
Copy link
Contributor Author

@ArthurZ it is better if you create a separate issue.

@ArthurZ
Copy link

ArthurZ commented Nov 1, 2015

Thank you @techtonik, submitted, #2794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants