Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require an equals sign for auto insert parens #2592

Closed
wants to merge 1 commit into from

Conversation

blink1073
Copy link
Contributor

Fixes #2581.

@goanpeca, there is no reliable way that I know of to detect whether we are on a continuation line for an import statement. With this change, there must be an = on the same line for auto-insert parens to work.

@goanpeca
Copy link
Member

goanpeca commented Aug 3, 2015

Ok, :-), I-ll take it for now then!

@ccordoba12
Copy link
Member

But what would happen with something like:

def my_function(x, y):
    return x + y

my<Tab>

?

We wouldn't have parens auto-inserted, right?

@blink1073
Copy link
Contributor Author

That is correct. You could always just insert the parens yourself. The more I think about this, the less I like the idea of adding the parens at all. I can see it being an annoyance more than a help.

@ccordoba12
Copy link
Member

We could also revert this feature, or leave it as proposed here.

The bad thing is that from our users perspective there'd be some inconsistency about when to expect parens to be auto-inserted. For example, I'd expect them to be inserted in the example I posted above.

@blink1073
Copy link
Contributor Author

Yes, but like I said, we'll never get it 100% right, and it is really annoying when we display it when the user doesn't want the behavior.

@ccordoba12
Copy link
Member

So revert? I don't have a problem with that :-) I'd prefer a consistent experience above the minimal effort of typing a single paren.

@blink1073
Copy link
Contributor Author

Closing in favor of #2602.

@blink1073 blink1073 closed this Aug 9, 2015
@ccordoba12 ccordoba12 removed this from the v3.0 milestone Oct 7, 2015
@blink1073 blink1073 deleted the no-parens-for-imports branch January 15, 2016 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants