Homogenize Object inspector UI #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,6 +199,42 @@ def setup_page(self): | |||
| self.setLayout(vlayout) | |||
|
|
|||
|
|
|||
| class FrameWebView(QFrame): | |||
There was a problem hiding this comment.
Please move this widget to
spyderlib/widgets/browser.py
because that's where we put all QWebKit widgets :-)
This is the only comment I have before merging (other than good job!)
|
@ccordoba12 done! |
| @@ -199,6 +199,7 @@ def setup_page(self): | |||
| self.setLayout(vlayout) | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove this empty blank line. It's not needed because there are already two blanks before it :-)
|
Thanks a lot for this. Things look much better now! :-) |
ccordoba12
added a commit
that referenced
this pull request
Aug 5, 2015
Homogenize Object inspector UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Insert QWebView inside a QFrame to homogenize the UI
Before
After