Add drag support for dockwidgets sharing same position #2369
Conversation
|
Nice ! Is it you playing the guitar on the video ? 😄 |
|
Hehe, no, the software I use puts the audio in, but i do play the guitar actually :-) Now ... well I am considering two things.. if ALL widgets have a corner menu (most do on the upper right corner...) then ybe the options should go there... or also in the tab if right clicking... I guess is natural to try to right click on a tab... |
|
It's natural to right click but I'd expect to see options about tab management, not about the content of the page. I don't know, maybe people would use it anyway... |
|
Yes that is what I want, to put tab related stuff... move to right, move to right end..., move to left, move to left end..., close tab, float panel... etc |
|
Honnestly I'm not sure the menu is worth it. In FIrefox I regularely have more than 50 tabs opened and it's a mess to manage, but in spyder I have at most 5 dockpanels at the same place, so actions like move to left or move to end are somewhat useless. |
|
I see what you mean, then this is almost ready :p |
|
First let me say that this is terrific addition!! Right now the way to reorganize dock widgets is to undock and dock them again, so this improves things by an order of magnitude!! I also agree with @Nodd, I think adding a contextual menu is too much. Let's leave things simple for now :-) |
|
Ok, I added some docstrings and is ready for a thorough revision ;-) @ccordoba12 Update I have a small bug I need to fix first |
|
@ccordoba12 this one is good to go, and easier to check (than the editor ine... that is still WIP) |
goanpeca
changed the title
| @@ -124,6 +126,14 @@ def __init__(self, *args, **kwargs): | |||
| if sys.platform == 'darwin': | |||
| self.setStyleSheet(self.DARWIN_STYLE) | |||
|
|
|||
| # Needed for the installation of the event filter | |||
| self.title = args[0] | |||
| self.main = args[1] | |||
There was a problem hiding this comment.
when create_dockwidget is called the args passed are the title and the parent (the main window in this case)
I agree is not so clear, but I am not so sure how to make it better...
There was a problem hiding this comment.
But we have get_plugin_title and self.main already. I don't get it ;-)
There was a problem hiding this comment.
But those things belong to the plugin, not to the dockwidget,
There was a problem hiding this comment.
I see. Then you need to redefine the init method of SpyderDockWidget to accept the right args, i.e. something like
def __init__(self, title, main, **kwargs):
super(SpyderDockWidget, self).__init__(**kwargs)
self.title = title
self.main = main
...
|
@ccordoba12 added corrections. With regard to the question of the dockwidget... |
| def tab_moved(self, event): | ||
| """Method called when a tab from a QTabBar has been moved.""" | ||
| # If the left button isn't pressed anymore then return | ||
| if not event.buttons() & Qt.LeftButton: |
There was a problem hiding this comment.
Why not a regular and, instead of & here?
There was a problem hiding this comment.
hmm True, proabably a leftover form the C++ code I took as example
There was a problem hiding this comment.
No I checked... buttons is an Or combination so I need the Binary And there...
| self.moving = False | ||
|
|
||
| def move_tab(self, start_tab, end_tab): | ||
| """Move a tab from a start to and end position.""" |
There was a problem hiding this comment.
to an end, not to and end :-)
| end_plugin = self._get_plugin(end_tab) | ||
|
|
||
| start = plugins.index(start_plugin) | ||
| end = plugins.index(end_plugin) |
There was a problem hiding this comment.
What about start_idx and end_idx for these variable names? I think they should be clearer ;-)
|
I renamed variables to be more consistent with the other PR (editor draggable tabs) and added support to call context menus if needed. For the moment the methods are empty, but I added them in case they are useful in the future. I also included the cursor fix so that it compensates when the moved tabs have different size. I made suggested corrections and everything now is working as expected :-), so if @ccordoba12 can check and approve, this one is ready. |
|
|
||
| def _get_plugins(self): | ||
| """ | ||
| Get a list of all the plugins references in the QTabBar to which this |
There was a problem hiding this comment.
Please change this to Get a list of all plugin references in the QTabbar ...
|
Nothing more from me to say :-) Please make my suggested changes so I can start testing. |
|
@ccordoba12 done |
|
|
||
| def show_nontab_menu(self): | ||
| """Show the context menu assigned to nontabs section.""" | ||
| pass |
There was a problem hiding this comment.
Las thing, I think I have the perfect suggestion for this entry
self.main.createPopupMenu()There was a problem hiding this comment.
There was a problem hiding this comment.
It shows the same context menu as when you do a right click over a toolbar.
Essentially, It shows the Help menu but with a few entries.
There was a problem hiding this comment.
Ok fixed it :), now this will only popup when clicking in an area where no tabs are present...
In this image I right clicked to the right of the File explorer Tab
|
@ccordoba12 you want to get the same context menu when right clicking on a tab as well?? I have two methods in this PR, one is |
|
I'd say yes, for now. But leave the two methods, so if we come up with a better context menu for tabs in the future, we can change it easily :-) |
|
Ready for testing @ccordoba12 |
|
Working great, even in PyQt5! Nothing else than merging ;-) |
Add drag and drop support for dockwidgets sharing the same position
Description
This related to dockwidgets that are tabified. Dockwidgets, when tabified, are put inside a QTabBar, but there is no access method to this bar, so to get it and process the event an eventFilter plus some search is needed.
I attach a video so you get the idea.