Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add constraint for pyqt5-sip on Python 3.8 (Dependencies) #23213

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 7, 2024

Description of Changes

  • A new version of that package was released yesterday which broke compatibility with Python 3.8, even when the other PyQt5 packages still support it.
  • Without this constraint Spyder fails to be installed in that Python version.
  • This commit was already included in PR: Update spyder-kernels to 3.0.2 #23201 for the 6.x branch, but we also need to have it in master until we drop support for that Python version.

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added type:Bug dependencies Pull requests that update a dependency file labels Dec 7, 2024
@ccordoba12 ccordoba12 added this to the v6.0.3 milestone Dec 7, 2024
@ccordoba12 ccordoba12 self-assigned this Dec 7, 2024
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 247:80: E501 line too long (106 > 79 characters)

@ccordoba12 ccordoba12 merged commit 91083d5 into spyder-ide:master Dec 7, 2024
17 checks passed
@ccordoba12 ccordoba12 deleted the fix-py38-pyqt5-error branch December 7, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants