PR: Fix UnboundLocalError when removing and adding paths to Pythonpath Manager
#22850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efined but not visible. This occurs when all paths are removed and then a new path is added, causing an error. Now the header is always destroyed and recreated, avoiding situation where the header is not visible.
mrclary
changed the title
ccordoba12
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Thanks for your work on this @mrclary! I left a suggestion and small question for you, the rest looks good to me.
Co-authored-by: Carlos Cordoba <[email protected]>
ccordoba12
changed the title
UnboundLocalError when removing and adding paths to PYTHONPATH Manager
ccordoba12
approved these changes
Nov 5, 2024
ccordoba12
changed the title
UnboundLocalError when removing and adding paths to PYTHONPATH ManagerUnboundLocalError when removing and adding paths to Pythonpath Manager
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Nov 5, 2024
…ng and adding paths to Pythonpath Manager
ccordoba12
pushed a commit
that referenced
this pull request
Nov 5, 2024
…moving and adding paths to Pythonpath Manager) (#22858)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix issue where
user_widgetwas not defined ifself.user_headerwas defined but not visible in the PYTHONPATH Manager widget.Reject PYTHONPATH paths that match conda base environment
/pkgsdirectory.Issue(s) Resolved
Fixes #22827