Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Register run metadata on renames for supported file extensions (Editor) #22820

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Nov 3, 2024

Description of Changes

  • This error happened, for instance, when renaming a Python file to a Markdown one. Since we were not checking if there's a run configuration for that file type, the new file was marked as available for running. And that led to errors when trying to run the entire file or a selection in it.
  • Add a test to prevent regressions about this in the future and modernize another test.

Issue(s) Resolved

Fixes #22630.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v6.0.3 milestone Nov 3, 2024
@ccordoba12 ccordoba12 self-assigned this Nov 3, 2024
Also, add a test to prevent regressions about that in the future.
That replaces the old tmpdir fixture and an unnecessary usage of
tempfile.TemporaryDirectory.
@ccordoba12 ccordoba12 merged commit 3bee638 into spyder-ide:master Nov 3, 2024
17 checks passed
@ccordoba12 ccordoba12 deleted the issue-22630 branch November 3, 2024 17:16
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Nov 3, 2024
ccordoba12 pushed a commit that referenced this pull request Nov 3, 2024
…s for supported file extensions (Editor)) (#22828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F9 (run selection) fails from .md file
1 participant