Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove unnecessary return in a try/finally statement (Files) #22745

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • That was preventing other errors generated there to be raised.
  • Also, replace old EnvironmentError by OSError and make some code style improvements.

Issue(s) Resolved

Fixes #22732

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

- That was preventing other errors generated there to be raised.
- Also, replace old EnvironmentError by OSError.
@ccordoba12 ccordoba12 added this to the v6.0.2 milestone Oct 28, 2024
@ccordoba12 ccordoba12 self-assigned this Oct 28, 2024
@ccordoba12 ccordoba12 merged commit 2b7208b into spyder-ide:master Oct 28, 2024
17 checks passed
@ccordoba12 ccordoba12 deleted the issue-22732 branch October 28, 2024 20:12
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Oct 28, 2024
ccordoba12 pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return in finally swallows exceptions
1 participant