PR: Show banner when the kernel is ready (IPython console) #22501
Conversation
|
@dalthviz, could you check that this works on Windows? For that you need to alternate between opening a console for the default env and a different one at least ten times. |
There was a problem hiding this comment.
Thanks @ccordoba12 ! Checked locally on Windows and I was unable to reproduce the issue (showing the consoles banner follows the preference)
Also, maybe some sort of test should be added to check this behavior (creating a new console follows the preference to show or not the initial banner)?
Anyhow, leaving this approved 👍
That's a good idea @dalthviz! I'll add one later today. |
- That helps us to understand when a race condition can happen between those actions. - Also, add log message when setting a Matplotlib backend in MatplotlibStatus widget.
The previous approach didn't work all the time because when the first prompt is shown, the kernel comm is not necessarily connected (and we need that to get the banner info).
ccordoba12
force-pushed
the
issue-22440
branch
from
011bf67 to
a4f357c
Compare
Also, add missing end of line to short banner and account for possible TimeoutError's when getting banners
ccordoba12
force-pushed
the
issue-22440
branch
from
a4f357c to
b1ae2d8
Compare
|
@dalthviz, we already had a test called |
|
@meeseeksdev please backport to 6.x |
…y (IPython console)
…ready (IPython console) ) (#22535) Co-authored-by: Carlos Cordoba <[email protected]>
Description of Changes
Issue(s) Resolved
Fixes #22440.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12