Don't add invalid paths to IMG_PATH #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens to work today because directories are only one level deep under images so "path" was always the same as "_root". Also, rename variables to match os.walk's documentation.
|
Any update on this one @ccordoba12, @ericfrederich ? |
| @@ -179,9 +179,9 @@ def add_image_path(path): | |||
| return | |||
| global IMG_PATH | |||
There was a problem hiding this comment.
Nothing to do with this PR, but why is this line necessary? IMG_PATH will be taken from the outer namespace. It would be necessary if there was IMG_PATH = something, but here we're only .append()ing to it.
|
We should merge this one, I see nothing wrong with this code. |
|
Ok, merging then per @Nodd's wishes ;-) |
ccordoba12
added a commit
that referenced
this pull request
Apr 30, 2015
Don't add invalid paths to IMG_PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens to work today because directories are only one level deep
under images so "path" was always the same as "_root".
Also, rename variables to match os.walk's documentation.