PR: Improve UI of status bar widgets (API/Completions) #22276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change color when those widgets are hovered and clicked. - Change cursor shape on hover.
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-07-21 22:59:37 UTC |
ccordoba12
force-pushed
the
improve-statusbar-ui
branch
from
32b0a0a to
d757b5f
Compare
- Fix its menu's position and use SpyderWidgetMixin API to build it. - Hide spinner after stopping it, which actually hides it from the status bar. - Change icon to signal that the server is down.
ccordoba12
force-pushed
the
improve-statusbar-ui
branch
from
d757b5f to
a9acad7
Compare
ccordoba12
force-pushed
the
improve-statusbar-ui
branch
from
a9acad7 to
6a1f1fe
Compare
ccordoba12
force-pushed
the
improve-statusbar-ui
branch
from
6a1f1fe to
1b01f2f
Compare
ccordoba12
changed the title
|
I discussed these changes with the UX team and they agree with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Visual changes
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: