PR: Fix Windows tunneling error when connecting to kernels (Remote client) #22223

hlouzada · 2024-07-02T08:42:58Z

Description of Changes

Wrote at least one-line docstrings (for any new functions)
Added unit test(s) covering the changes (if testable)

Included a screenshot or animation (if affecting the UI, see Licecap)

Paramiko in Windows with/or Windows native SSH Client (Win32-OpenSSH) doesn't tunnel successfully, probably due to PowerShell/Win32-OpenSSH#999.

So it was used asyncssh that reimplements the Open SSH protocol in Python.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @hlouzada

pep8speaks · 2024-07-02T08:43:04Z

Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-16 15:57:29 UTC

dalthviz · 2024-07-02T22:35:52Z

Gave this a quick check on Windows and I'm being able to connect to the server on first try 👍 However, I'm getting an error related with the spyder-kernels version (need >= 3.0.0b7):

Probably the spyder-remote-server repo needs to be updated to follow latest constraints update since Spyder 6.0.0b2 was released? 🤔

hlouzada · 2024-07-02T23:43:26Z

Gave this a quick check on Windows and I'm being able to connect to the server on first try 👍 However, I'm getting an error related with the spyder-kernels version (need >= 3.0.0b7):

Probably the spyder-remote-server repo needs to be updated to follow latest constraints update since Spyder 6.0.0b2 was released? 🤔

Exactly. I've just updated spyder-remote-kernels to install spyder-kernels=3.0.0b7. Please reinstall the remote server and test again.

dalthviz · 2024-07-03T20:07:55Z

Gave this another check and things are working for me on my Windows machine 👍 I'm now able to connect to a docker container and start a console connected to a kernel create using the spyder-remote-server 🎉

…hen restarting kernels

- That's to be more consistent with the naming used in Jupyter. - Also, since this is a supporting class, move it to be before the SpyderKernelClient one.

- That signal doesn't require anymore two signatures, so we can remove the unused one. - Also, use functools.partial to simplify the code for a slot.

ccordoba12

I tested this on my Windows VM and it's working as expected. Great work @hlouzada!

dalthviz · 2024-07-12T01:01:56Z

Gave this another check and seems like launching a console, restarting the kernel and removing variables works 👍 However, I was able to trigger an error by stopping the server connection while having multiple consoles open. I got the following traceback:

exception calling callback for <Future at 0x2121550c3d0 state=finished raised ClientConnectorError>
Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1025, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1065, in create_connection
    raise exceptions[0]
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\proactor_events.py", line 703, in sock_connect
    return await self._proactor.connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 604, in finish_connect
    ov.getresult()
ConnectionRefusedError: [WinError 1225] El equipo remoto rechazó la conexión de red

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\api\asyncdispatcher.py", line 128, in _callback_task_done
    raise exception
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\plugin.py", line 316, in _shutdown_kernel
    await client.terminate_kernel(kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\client.py", line 719, in terminate_kernel
    response = await jupyter.delete_kernel(kernel_id=kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\jupyterhub\__init__.py", line 343, in delete_kernel
    async with self.session.delete(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 1197, in __aenter__
    self._resp = await self._coro
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 581, in _request
    conn = await self._connector.connect(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 544, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 944, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1257, in _create_direct_connection
    raise last_exc
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1226, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1033, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host 127.0.0.1:52429 ssl:default [El equipo remoto rechazó la conexión de red]
exception calling callback for <Future at 0x212154f7250 state=finished raised ClientConnectorError>
Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1025, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1065, in create_connection
    raise exceptions[0]
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\proactor_events.py", line 703, in sock_connect
    return await self._proactor.connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 604, in finish_connect
    ov.getresult()
ConnectionRefusedError: [WinError 1225] El equipo remoto rechazó la conexión de red

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\api\asyncdispatcher.py", line 128, in _callback_task_done
    raise exception
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\plugin.py", line 316, in _shutdown_kernel
    await client.terminate_kernel(kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\client.py", line 719, in terminate_kernel
    response = await jupyter.delete_kernel(kernel_id=kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\jupyterhub\__init__.py", line 343, in delete_kernel
    async with self.session.delete(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 1197, in __aenter__
    self._resp = await self._coro
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 581, in _request
    conn = await self._connector.connect(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 544, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 944, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1257, in _create_direct_connection
    raise last_exc
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1226, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1033, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host 127.0.0.1:52429 ssl:default [El equipo remoto rechazó la conexión de red]

Not sure if that error is expected or if it is even actually related with the work here though 🤔

hlouzada · 2024-07-12T14:22:26Z

Gave this another check and seems like launching a console, restarting the kernel and removing variables works 👍 However, I was able to trigger an error by stopping the server connection while having multiple consoles open. I got the following traceback:

exception calling callback for <Future at 0x2121550c3d0 state=finished raised ClientConnectorError>
Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1025, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1065, in create_connection
    raise exceptions[0]
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\proactor_events.py", line 703, in sock_connect
    return await self._proactor.connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 604, in finish_connect
    ov.getresult()
ConnectionRefusedError: [WinError 1225] El equipo remoto rechazó la conexión de red

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\api\asyncdispatcher.py", line 128, in _callback_task_done
    raise exception
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\plugin.py", line 316, in _shutdown_kernel
    await client.terminate_kernel(kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\client.py", line 719, in terminate_kernel
    response = await jupyter.delete_kernel(kernel_id=kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\jupyterhub\__init__.py", line 343, in delete_kernel
    async with self.session.delete(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 1197, in __aenter__
    self._resp = await self._coro
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 581, in _request
    conn = await self._connector.connect(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 544, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 944, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1257, in _create_direct_connection
    raise last_exc
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1226, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1033, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host 127.0.0.1:52429 ssl:default [El equipo remoto rechazó la conexión de red]
exception calling callback for <Future at 0x212154f7250 state=finished raised ClientConnectorError>
Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1025, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1065, in create_connection
    raise exceptions[0]
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\proactor_events.py", line 703, in sock_connect
    return await self._proactor.connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 604, in finish_connect
    ov.getresult()
ConnectionRefusedError: [WinError 1225] El equipo remoto rechazó la conexión de red

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\api\asyncdispatcher.py", line 128, in _callback_task_done
    raise exception
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\plugin.py", line 316, in _shutdown_kernel
    await client.terminate_kernel(kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\client.py", line 719, in terminate_kernel
    response = await jupyter.delete_kernel(kernel_id=kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\jupyterhub\__init__.py", line 343, in delete_kernel
    async with self.session.delete(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 1197, in __aenter__
    self._resp = await self._coro
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 581, in _request
    conn = await self._connector.connect(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 544, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 944, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1257, in _create_direct_connection
    raise last_exc
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1226, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1033, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host 127.0.0.1:52429 ssl:default [El equipo remoto rechazó la conexión de red]

Not sure if that error is expected or if it is even actually related with the work here though 🤔

This is triggering an error because it tries to delete the kernel after the connection is closed.

We should first close any created kernels before terminating the connection in the widget disconnect routine. However, I believe that we should address this issue in another PR as this is unrelated to this PR scope.

ccordoba12 · 2024-07-12T15:38:18Z

We should first close any created kernels before terminating the connection in the widget disconnect routine.

We can't do that because the scenario @dalthviz simulated (he told me about that internally) was breaking the connection to the server by shutting down the Docker machine.

In that case, I decided to close all consoles automatically because it makes little sense to leave them open when there's no possibility of reconnection. And closing a console requests to shutdown its associated kernel.

However, I believe that we should address this issue in another PR as this is unrelated to this PR scope.

Well, I think the fix is not that hard: we can either catch the ClientConnectorError in RemoteClient._shutdown_kernel; or check if the connection is active in that method before requesting a shutdown to the server.

What do you think?

hlouzada · 2024-07-15T19:04:08Z

We should first close any created kernels before terminating the connection in the widget disconnect routine.

We can't do that because the scenario @dalthviz simulated (he told me about that internally) was breaking the connection to the server by shutting down the Docker machine.

In that case, I decided to close all consoles automatically because it makes little sense to leave them open when there's no possibility of reconnection. And closing a console requests to shutdown its associated kernel.

However, I believe that we should address this issue in another PR as this is unrelated to this PR scope.

Well, I think the fix is not that hard: we can either catch the ClientConnectorError in RemoteClient._shutdown_kernel; or check if the connection is active in that method before requesting a shutdown to the server.

What do you think?

I agree, that this is an easy fix but the plugin should also handle the any disconnection error mid session properly without raising any errors. I'll push this quick fix with the exception handling, but we should further address this matter in another PR.

dalthviz · 2024-07-15T22:04:59Z

So, just in case and to give some clarity over the testing I have been doing, the steps I used to raise the error I posted above were launching multiple console and then clicking the Stop button (the one in the connections dialog). With the latest changes no error in that case is being raised anymore.

However, the case @ccordoba12 describes (for some reason the connection to the server gets interrupted from outside Spyder, e.g the docker instance you are connected is stopped from outside Spyder) could also be a possible one and checking it, even with the latest changes, an error is raised:

exception calling callback for <Future at 0x25e59fb1400 state=finished raised ClientConnectorError>
Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1025, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1065, in create_connection
    raise exceptions[0]
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\proactor_events.py", line 703, in sock_connect
    return await self._proactor.connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 604, in finish_connect
    ov.getresult()
ConnectionRefusedError: [WinError 1225] El equipo remoto rechazó la conexión de red

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\api\asyncdispatcher.py", line 128, in _callback_task_done
    raise exception
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\plugin.py", line 338, in _restart_kernel
    return await client.restart_kernel(kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\client.py", line 739, in restart_kernel
    response = await jupyter.restart_kernel(kernel_id=kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\jupyterhub\__init__.py", line 367, in restart_kernel
    async with self.session.post(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 1197, in __aenter__
    self._resp = await self._coro
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 581, in _request
    conn = await self._connector.connect(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 544, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 944, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1257, in _create_direct_connection
    raise last_exc
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1226, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1033, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host 127.0.0.1:58777 ssl:default [El equipo remoto rechazó la conexión de red]
exception calling callback for <Future at 0x25e59fb1400 state=finished raised ClientConnectorError>
Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1025, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1065, in create_connection
    raise exceptions[0]
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\proactor_events.py", line 703, in sock_connect
    return await self._proactor.connect(sock, address)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 817, in _poll
    value = callback(transferred, key, ov)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\asyncio\windows_events.py", line 604, in finish_connect
    ov.getresult()
ConnectionRefusedError: [WinError 1225] El equipo remoto rechazó la conexión de red

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\widgets\container.py", line 282, in <lambda>
    ipyclient, future.result()
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 439, in result
    return self.__get_result()
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 391, in __get_result
    raise self._exception
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\concurrent\futures\_base.py", line 330, in _invoke_callbacks
    callback(self)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\api\asyncdispatcher.py", line 128, in _callback_task_done
    raise exception
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\plugin.py", line 338, in _restart_kernel
    return await client.restart_kernel(kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\client.py", line 739, in restart_kernel
    response = await jupyter.restart_kernel(kernel_id=kernel_id)
  File "E:\Acer\Documentos\Spyder\Spyder otros\hlouzada\spyder\spyder\plugins\remoteclient\api\jupyterhub\__init__.py", line 367, in restart_kernel
    async with self.session.post(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 1197, in __aenter__
    self._resp = await self._coro
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\client.py", line 581, in _request
    conn = await self._connector.connect(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 544, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 944, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1257, in _create_direct_connection
    raise last_exc
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1226, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "C:\Users\dalth\anaconda3\envs\spyder-dev\lib\site-packages\aiohttp\connector.py", line 1033, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host 127.0.0.1:58777 ssl:default [El equipo remoto rechazó la conexión de red]

Which I think is related with the console trying to restart the kernel.

Nevertheless, as @hlouzada says, there should be a proper disconnection handling logic that takes into account the multiple scenarios where a connection to a server is closed/terminated (from within Spyder or from outside Spyder)

dalthviz · 2024-07-15T22:12:28Z

Also, following the above, should this be merged as it is or a similar band-aid/temporary approach for the kernel restart traceback should be done first here @ccordoba12 @hlouzada ? I will leave this approved but let me know if further changes are done and testing needs to be done 👍

ccordoba12 · 2024-07-16T16:01:22Z

So, just in case and to give some clarity over the testing I have been doing, the steps I used to raise the error I posted above were launching multiple console and then clicking the Stop button (the one in the connections dialog). With the latest changes no error in that case is being raised anymore.

Ok, thanks for the clarification @dalthviz.

However, the case @ccordoba12 describes (for some reason the connection to the server gets interrupted from outside Spyder, e.g the docker instance you are connected is stopped from outside Spyder) could also be a possible one and checking it, even with the latest changes, an error is raised

This is the scenario I thought you checked, but thanks for doing it and posting the results here!

Also, following the above, should this be merged as it is or a similar band-aid/temporary approach for the kernel restart traceback should be done first here @ccordoba12 @hlouzada ?

Good idea. I amended @hlouzada's last commit to include another temporary fix for that problem. After CIs are green, I'll merge.

ialvata · 2025-01-24T18:01:39Z

When trying to connect to a remote Linux target, from a local Windows source, using Spyder 6.0.3, I get the following error:
Error: Failed to open ssh conection: Host key is not trusted for host *****
I can connect with PuTTY, after accepting for the 1st time the key, without any problems.
I thought asyncssh had PuTTY support though...

Not sure whether it's a problem on your part, or on the asyncssh package (file connection.py, line 3485)

dalthviz · 2025-01-29T15:34:09Z

Hi @ialvata thank you for the feedback! I would suggest you to open a new issue about that. From a quick check, a way that occurs to me to workaround the issue is to do an initial manual connection to your Linux remote machine outside Spyder (for example using a powershell instance) to add the remote machine to the known_hosts file. Seems like PuTTy, it doesn't add entries to the known_host file and instead stores that information over the registry (https://superuser.com/questions/197489/where-does-putty-store-known-hosts-information-on-windows).

Let us know if the info above helps!

dalthviz added this to the v6.0beta3 milestone Jul 2, 2024

dalthviz assigned hlouzada Jul 2, 2024

dalthviz added type:Bug component:Remote client OS:Windows labels Jul 2, 2024

dalthviz changed the title ~~Fix windows kernel tunneling error~~ PR: Fix windows kernel tunneling error Jul 2, 2024

dalthviz requested a review from ccordoba12 July 3, 2024 20:10

hlouzada force-pushed the fix-windows-kernel-tunneling-error branch from 9ab05c6 to 9eadbc9 Compare July 3, 2024 22:31

hlouzada force-pushed the fix-windows-kernel-tunneling-error branch from 51f29d5 to 0995ed5 Compare July 10, 2024 23:49

hlouzada added 10 commits July 10, 2024 20:55

fix: use asyncssh to create kernel tunnels, refactor kernel creation

65f2925

fix: refactor creating kernels handlers and tunneling with new api

719d666

fix: use same async loop for all asyncssh related loops

3337289

fix: wrong parameter

6da3b72

fix: wrong variable in writing new connection info file

3ae7580

fix: handle errors on creating kernel handlers

54aa862

fix: return connection info key as string not as bytes

1fdfe99

fix: update wrong variable names

6717e9d

fix: ensure that the tunnels are deleted and new handler is created w…

3496bc0

…hen restarting kernels

refactor: format with black

c89a473

hlouzada force-pushed the fix-windows-kernel-tunneling-error branch from 451a604 to c89a473 Compare July 11, 2024 00:00

fix: remove super del python magic method

f24f213

ccordoba12 changed the title ~~PR: Fix windows kernel tunneling error~~ PR: Fix Windows tunneling error when connecting to kernels (Remote client) Jul 11, 2024

ccordoba12 added 3 commits July 11, 2024 09:36

IPython console: Rename ClientKernelTunneler to KernelClientTunneler

39a8be1

- That's to be more consistent with the naming used in Jupyter. - Also, since this is a supporting class, move it to be before the SpyderKernelClient one.

Remote client: Simplify signature of _sig_kernel_restarted

8dcda38

- That signal doesn't require anymore two signatures, so we can remove the unused one. - Also, use functools.partial to simplify the code for a slot.

Remove dependency on Paramiko because it's no longer needed

ca78ab5

ccordoba12 requested a review from dalthviz July 11, 2024 15:08

ccordoba12 approved these changes Jul 11, 2024

View reviewed changes

dalthviz approved these changes Jul 15, 2024

View reviewed changes

fix: ignore errors on closing client and kernels

d5f8088

ccordoba12 force-pushed the fix-windows-kernel-tunneling-error branch from 4bef7a6 to d5f8088 Compare July 16, 2024 15:57

ccordoba12 merged commit e1fc1a9 into spyder-ide:master Jul 16, 2024
23 checks passed

dalthviz mentioned this pull request Jul 16, 2024

Spyder 6.0 beta3 release #22262

Closed

ccordoba12 mentioned this pull request Jul 29, 2024

PR: Handle remote connection lost (Remote client) #22285

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Fix Windows tunneling error when connecting to kernels (Remote client) #22223

PR: Fix Windows tunneling error when connecting to kernels (Remote client) #22223

hlouzada commented Jul 2, 2024

pep8speaks commented Jul 2, 2024 •

edited

Loading

dalthviz commented Jul 2, 2024

hlouzada commented Jul 2, 2024 •

edited

Loading

dalthviz commented Jul 3, 2024

ccordoba12 left a comment •

edited

Loading

dalthviz commented Jul 12, 2024 •

edited

Loading

hlouzada commented Jul 12, 2024

ccordoba12 commented Jul 12, 2024 •

edited

Loading

hlouzada commented Jul 15, 2024

dalthviz commented Jul 15, 2024

dalthviz commented Jul 15, 2024

ccordoba12 commented Jul 16, 2024 •

edited

Loading

ialvata commented Jan 24, 2025 •

edited

Loading

dalthviz commented Jan 29, 2025 •

edited

Loading

PR: Fix Windows tunneling error when connecting to kernels (Remote client) #22223

PR: Fix Windows tunneling error when connecting to kernels (Remote client) #22223

Conversation

hlouzada commented Jul 2, 2024

Description of Changes

Affirmation

pep8speaks commented Jul 2, 2024 • edited Loading

Comment last updated at 2024-07-16 15:57:29 UTC

dalthviz commented Jul 2, 2024

hlouzada commented Jul 2, 2024 • edited Loading

dalthviz commented Jul 3, 2024

ccordoba12 left a comment • edited Loading

Choose a reason for hiding this comment

dalthviz commented Jul 12, 2024 • edited Loading

hlouzada commented Jul 12, 2024

ccordoba12 commented Jul 12, 2024 • edited Loading

hlouzada commented Jul 15, 2024

dalthviz commented Jul 15, 2024

dalthviz commented Jul 15, 2024

ccordoba12 commented Jul 16, 2024 • edited Loading

ialvata commented Jan 24, 2025 • edited Loading

dalthviz commented Jan 29, 2025 • edited Loading

pep8speaks commented Jul 2, 2024 •

edited

Loading

hlouzada commented Jul 2, 2024 •

edited

Loading

ccordoba12 left a comment •

edited

Loading

dalthviz commented Jul 12, 2024 •

edited

Loading

ccordoba12 commented Jul 12, 2024 •

edited

Loading

ccordoba12 commented Jul 16, 2024 •

edited

Loading

ialvata commented Jan 24, 2025 •

edited

Loading

dalthviz commented Jan 29, 2025 •

edited

Loading