Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix issue where Spyder's inline graphics preferences were not applied #22088

Merged
merged 9 commits into from
May 31, 2024
Merged

PR: Fix issue where Spyder's inline graphics preferences were not applied #22088

merged 9 commits into from
May 31, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented May 16, 2024 •
edited by ccordoba12
Loading

Description of Changes

Issue(s) Resolved

Fixes #22034
Fixes #10932

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@mrclary mrclary self-assigned this May 16, 2024
@mrclary mrclary force-pushed the issue-22034 branch 3 times, most recently from 5c8bf7b to 53e2ab8 Compare May 18, 2024 00:56
@mrclary mrclary mentioned this pull request May 18, 2024
Closed
10 tasks
@mrclary mrclary force-pushed the issue-22034 branch 2 times, most recently from 9bf3e2e to f0f0978 Compare May 24, 2024 20:55
@pep8speaks
Copy link

pep8speaks commented May 24, 2024 •
edited
Loading

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-05-31 20:41:00 UTC

@mrclary mrclary marked this pull request as ready for review May 25, 2024 04:34
@mrclary mrclary requested a review from ccordoba12 May 25, 2024 04:34
@mrclary mrclary force-pushed the issue-22034 branch 3 times, most recently from e73fda1 to d774fdf Compare May 29, 2024 20:11
@ccordoba12 ccordoba12 changed the title Fix issue where Spyder's inline graphics preferences were not applied PR: Fix issue where Spyder's inline graphics preferences were not applied May 30, 2024
@ccordoba12 ccordoba12 added this to the v6.0beta2 milestone May 30, 2024
ccordoba12
ccordoba12 reviewed May 30, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I think it's missing a test to check that Matplotlib rcParams are effectively different between the inline and interactive backends.

@mrclary
Copy link
Contributor Author

mrclary commented May 30, 2024

This looks good to me but I think it's missing a test to check that Matplotlib rcParams are effectively different between the inline and interactive backends.

Good idea. I'll create a test.

ccordoba12
ccordoba12 reviewed May 31, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary for the new test!

spyder/plugins/ipythonconsole/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/conftest.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
mrclary and others added 8 commits May 31, 2024 11:47
@mrclary
When activating graphics support, send all inline configurations to t…
2cd3562 
…he kernel.
@mrclary
Do not set a default InlineBackend configuration in spyder kernels.
f70f90e 
This prevents user's matplotlib rc parameters from being clobbered when Spyder's "Activate support" is disabled. This makes sense because when disabled, a user should expect that Spyder does not interfere in any way.
@mrclary
Require kernel restart if deactivating graphics support.
6bdb94d
@mrclary
Only set kernel configuration for matplotlib if graphics support is a…
f1fcefd 
…ctivated.
@mrclary
PEP8
2ffcf4c
@mrclary
Add test for rcParams when backend changes between interactive and in…
9ac8ac9 
…line
@mrclary @ccordoba12
Apply suggestions from code review
bdda9ff 
Co-authored-by: Carlos Cordoba <[email protected]>
@mrclary
git subrepo pull (merge) --branch=master --remote=https://github.com/…
94d0aa1 
…spyder-ide/spyder-kernels.git --update --force external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "ea047533c"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "ea047533c"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
ccordoba12
ccordoba12 approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 7997b72 into spyder-ide:master May 31, 2024
14 checks passed
@mrclary mrclary deleted the issue-22034 branch May 31, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@mrclary mrclary

Labels
component:IPython Console type:Bug
Projects
None yet
Milestone
v6.0beta2
3 participants
@mrclary @pep8speaks @ccordoba12