PR: Additional UI improvements to the About Spyder dialog
#21641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use constant for border radius in tabs.
- Use the same tabbar style as the one in Preferences. - Fix margins and background color due to that. - Move css tweaks to a separate method.
- The used scale factor is the one set by users in Preferences for the main screen. - Also, fix error when getting the scale factor used for the splash screen.
- That prevents showing it pixelated for scale factors greater than 1. - Also, simplify string replacements in info QLabel.
- Reduce space between icon and version info. - Make left/right margin around icon and version uniform. - Center tabbar on scroll areas. - Use a darker color for borders. - Create additional methods for the style applied to different widgets.
That's because it's easier to visually grasp than the filled version of it. And it's also more standard.
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-12-23 00:25:08 UTC |
ccordoba12
changed the title
About Spyder dialogAbout Spyder dialog
ccordoba12
force-pushed
the
improve-about-dialog
branch
4 times, most recently
from
c5d2962 to
da79e2e
Compare
- Also, make some minor improvements to the text shown on it per review. - Rename MARGIN class constant to PADDING because it makes more sense. - Fix modules tests, some comments and docstrings.
ccordoba12
force-pushed
the
improve-about-dialog
branch
from
da79e2e to
c151f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
MessageBoxInformationicon to its outline version because it's more standard and easier to grasp.spyder/widgets.Visual changes
Before
After
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12