Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix Installer workflow on schedule and add badge to Readme #21343

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Sep 15, 2023

  • Fixed typo that prevented using subrepos on schedule trigger.
  • Fixed logic to notarize on schedule trigger.
  • Added status badge to repo landing page.

In addition to the status badge, scheduled workflow failures will trigger notifications to the last person to enable the workflow or set the cron schedule (currently @mrclary). This is set in the user's notification setttings of his/her GitHub profile.

@mrclary mrclary self-assigned this Sep 15, 2023
@mrclary mrclary requested a review from ccordoba12 September 15, 2023 19:34
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion, the rest looks good to me.

README.md Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v6.0alpha3 milestone Sep 15, 2023
@ccordoba12 ccordoba12 changed the title PR: Fix Installer Workflow on Schedule and Add Badge PR: Fix Installer workflow on schedule and add badge to Readme Sep 15, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 00987d8 into spyder-ide:master Sep 15, 2023
@mrclary mrclary deleted the schedule-fix branch September 16, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants