PR: Support all real number dtypes in dataframe editor #21295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is a small PR which uses the new function
pandas.api.types.is_any_real_numeric_dtype()
to decide whether a Pandas dtype is a real number and thus gets the background colouring of numbers in the Dataframe editor. This allows us to supports the nullable integer types and also numeric types that were previously not supported likenumpy.int16
. A test is also included.This PR imports
pandas
inside a function. As far as I can see, no part of Spyder explicitly importspandas
but I think thatpandas
is always imported when a Dataframe editor is opened, so this should not be a problem.Screenshot after:
Screenshot before:
These are produced using the following code, from issue #21022:
Issue(s) Resolved
Fixes #21222
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jitse Niesen