Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Do not include spyder-terminal in standalone applications #21266

Merged
merged 1 commit into from
Aug 18, 2023
Merged

PR: Do not include spyder-terminal in standalone applications #21266

merged 1 commit into from
Aug 18, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Aug 17, 2023

Description of Changes

Removed spyder-terminal plugin from the standalone applications

Issue(s) Resolved

Fixes #21258

@mrclary mrclary requested review from dalthviz and ccordoba12 August 17, 2023 17:42
@mrclary mrclary self-assigned this Aug 17, 2023
dalthviz
dalthviz reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary ! Seems like the macOS app is failing to be build (no idea why 🤔)

From the Windows side of things, checked locally and seems like the installer is working 👍

@mrclary
Copy link
Contributor Author

mrclary commented Aug 18, 2023

Thanks @mrclary ! Seems like the macOS app is failing to be build (no idea why 🤔)

From the Windows side of things, checked locally and seems like the installer is working 👍

Sorry, I think I found the issue. An oversight on my part. I think it should work now.

@ccordoba12 ccordoba12 added this to the v5.5.0 milestone Aug 18, 2023
ccordoba12
ccordoba12 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@mrclary mrclary closed this Aug 18, 2023
@mrclary mrclary deleted the issue-21258a branch August 18, 2023 18:08
@mrclary mrclary restored the issue-21258a branch August 18, 2023 18:20
@mrclary mrclary reopened this Aug 18, 2023
@ccordoba12
Copy link
Member

Merging because @dalthviz said there are no problems with the Windows installer.

@ccordoba12 ccordoba12 merged commit ae3ede8 into spyder-ide:5.x Aug 18, 2023
ccordoba12 added a commit that referenced this pull request Aug 18, 2023
@ccordoba12
Merge from 5.x: PR #21266
fcfc257 
Fixes #21258
@mrclary mrclary deleted the issue-21258a branch August 18, 2023 23:46
@ccordoba12 ccordoba12 mentioned this pull request Sep 21, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz left review comments

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@mrclary mrclary

Labels
Installers type:Task
Projects
None yet
Milestone
v5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrclary @ccordoba12 @dalthviz