Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move Editor API inside the plugin (Editor) #21210

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Aug 2, 2023

Description of Changes

Move Editor related API elements from the general Spyder API to the Editor API

Supersedes #13436

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz self-assigned this Aug 2, 2023
@dalthviz dalthviz added this to the v6.0alpha2 milestone Aug 2, 2023
@dalthviz dalthviz marked this pull request as ready for review August 2, 2023 22:26
@dalthviz dalthviz requested a review from ccordoba12 August 2, 2023 22:26
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment for you @dalthviz, the rest looks good to me.

spyder/api/editor.py Show resolved Hide resolved
@dalthviz dalthviz requested a review from ccordoba12 August 3, 2023 22:51
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 57d1e1e into spyder-ide:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants