Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add new icons for replace next, all and selection buttons #20972

Merged
merged 2 commits into from
May 29, 2023

Conversation

conradolandia
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

image

  • Removed the old generic icon references in spyder/utils/icon_manager.py.
  • Added files:
    • spyder/images/dark/replace_all.svg
    • spyder/images/dark/replace_next.svg
    • spyder/images/dark/replace_selection.svg
    • spyder/images/light/replace_all.svg
    • spyder/images/light/replace_next.svg
    • spyder/images/light/replace_selection.svg

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

conradolandia

@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone May 29, 2023
@ccordoba12 ccordoba12 changed the title Added new icons for replace_next, replace_all and replace_selection PR: Add new icons for replace next, all and selection buttons May 29, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @conradolandia! I really like this new set of icons.

I also tested your PR locally and it's working as expected.

@ccordoba12 ccordoba12 merged commit c82d376 into spyder-ide:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants