-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Change reporting of macOS system from Darwin to macOS and include machine type #20823
Conversation
@spyder-ide/core-developers, what do you think about this PR? |
Sounds like a good idea @mrclary ! Maybe is worthy to add this change in 5.x too? |
I have no problem with that, depending on what others have to say. |
@spyder-ide/core-developers, do you think this should be moved to 5.x? |
+1 from me. For that (if others think that's ok), please use following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mrclary!
@dalthviz, did you want to say anything or are you good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary ! Checked locally the changes on Windows and LGTM 👍
As a suggestion it could be nice to have a test that runs on macOS, Linux and Windows checking the dialog since I think the only test that we have for the dialog is the one at the end of the file which only is run on Linux 🤔
Anyhow, not something to prevent this from being merged 👍
…hine type for all platforms.
Let's merge this one. |
Description of Changes
In About widget, changed system info reporting for macOS from "Darwin" to "macOS" with appropriately changed release designation.
Also added machine type ('arm64', 'x86_64', 'AMD64', etc) to the system info for all platforms.
In the system info for issue reporting (and "Copy version info" of About widget), operating system value is replaced with the value of
platform.platform
."macOS 13.3" is more meaningful than "Darwin 22.4.0" to users, issue reporters, and developers. Additionally, inclusion of machine type may eliminate the need for developers to ask issue reporters "Is your machine Intel or M1?".
New "About" widget text
New Issue text