Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Initial code changes for old menu actions to use the Mainmenu plugin (Editor) #20620

Merged
merged 7 commits into from
Mar 14, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Mar 2, 2023

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Move menu actions from the Editor code to use Mainmenu plugin:

  • Edit menu
  • Search menu
  • Source menu

Issue(s) Resolved

Part of #17468

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz requested a review from ccordoba12 March 9, 2023 23:48
@dalthviz dalthviz changed the title [WIP] PR: Initial menu actions code changes to use Mainmenu plugin (Editor) PR: Initial menu actions code changes to use Mainmenu plugin (Editor) Mar 9, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for your work on this! Some small suggestions for you, otherwise looks good to me.

spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/editor/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/pylint/plugin.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Initial menu actions code changes to use Mainmenu plugin (Editor) PR: Initial code changes for old menu actions to use the Mainmenu plugin (Editor) Mar 13, 2023
@dalthviz dalthviz requested a review from ccordoba12 March 13, 2023 23:49
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 9a1ca89 into spyder-ide:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants