Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix installer triggers #20466

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Feb 3, 2023

Opening a PR and labeling it at the same time results in a race condition between the opened and labeled pull_request event triggers which can lead to cancelled installer workflows.

To fix this, we remove the labeled event trigger for pull_requests.
Since release candidates were the primary motivation for these triggers, but this must rely on the workflow_dispatch trigger anyway, the workflow_dispatch is now the recommended way to trigger workflows outside of pull_request and release events.

Additionally, inputs for the workflow_dispatch were added to the conda-based installer workflow for enhanced flexibility.

  • pull_request.labeled trigger events are removed for installer workflows
  • push.tag trigger events are removed for installer workflows
  • workflow_dispatch trigger is added to unit test workflows. These can now be triggered to run on arbitrary branches, independent of pull_requests.
  • inputs are added to the workflow_dispatch in conda-based installer workflow
    • "Build as release candidate": build the installers using released versions of qtconsole, python-lsp-server, and spyder-kernels; codesign and notarize the resulting installers (macOS only). If deselected, qtconsole, python-lsp-server, and spyder-kernels are built from the upstream remote and commit specified in external-deps
    • "Build macOS installer": build the macOS installer
    • "Build Linux installer": build the Linux installer
    • "Build Windows installer": build the Windows installer

@mrclary mrclary force-pushed the fix-installer-triggers branch from 9ec648b to b36e96e Compare February 3, 2023 00:20
@mrclary mrclary requested a review from ccordoba12 February 3, 2023 02:51
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@ccordoba12 ccordoba12 added this to the v5.4.3 milestone Feb 3, 2023
@ccordoba12 ccordoba12 merged commit 9462414 into spyder-ide:5.x Feb 3, 2023
ccordoba12 added a commit that referenced this pull request Feb 3, 2023
@mrclary mrclary deleted the fix-installer-triggers branch February 3, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants