Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Correctly handle the option to run in a dedicated console without clearing variables #20012

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

bcolsen
Copy link
Member

@bcolsen bcolsen commented Nov 8, 2022

Description of Changes

Added the option to run in a dedicated console without clearing variables. I forgot to make a branch in #19984 so I'm replacing it with this one.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Added the option to run in a dedicated console without clearing variables because it seems like that should be an option and I like my interactive plot windows to stay in place and not pop up all the time

Issue(s) Resolved

Fixes #19983

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: bcolsen

@dalthviz dalthviz changed the title Added the option to run in a dedicated console without clearing variables PR: Added correct handling for the option to run in a dedicated console without clearing variables Nov 10, 2022
@dalthviz dalthviz added this to the v5.4.1 milestone Nov 10, 2022
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcolsen for the help with this! Left a suggestion for the comment on the new case added to the tests when changing the clear_namespace config.

Other than that this LGTM 👍

spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Added correct handling for the option to run in a dedicated console without clearing variables PR: Correctly handle the option to run in a dedicated console without clearing variables Nov 13, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcolsen!

Note: The failure in our tests is unrelated to this.

@ccordoba12 ccordoba12 merged commit 66892bb into spyder-ide:5.x Nov 15, 2022
ccordoba12 added a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants