Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move debug cell / file / config to Debugger plugin #19181

Merged
merged 13 commits into from
Aug 31, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Aug 25, 2022

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 85:80: E501 line too long (89 > 79 characters)

Comment last updated at 2022-08-30 20:49:46 UTC

@impact27 impact27 changed the title PR: Move debug config PR: Move debug cell / file / config to debug plugin Aug 25, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @impact27 for your help with this!

spyder/plugins/debugger/confpage.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/confpage.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Aug 28, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of reviews for you @impact27.

spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Move debug cell / file / config to debug plugin PR: Move debug cell / file / config to Debugger plugin Aug 30, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last review @impact27, then this should be ready.

spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants