Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Rename FramesExplorer plugin to Debugger #18852

Merged
merged 3 commits into from
Aug 3, 2022
Merged

PR: Rename FramesExplorer plugin to Debugger #18852

merged 3 commits into from
Aug 3, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Jul 28, 2022 •
edited
Loading

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-03 05:04:14 UTC

@ccordoba12 ccordoba12 changed the title PR: Rename FramesExplorer to Debugger, depends on #18514 PR: Rename FramesExplorer plugin to Debugger Aug 2, 2022
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Aug 2, 2022
@impact27 impact27 force-pushed the rename_framesexplorer branch from 39b99b0 to 8e02a7b Compare August 2, 2022 19:56
rename frames explorer to debugger
2e19177 
This reverts commit 22bcbdd.
fix test
@impact27 impact27 force-pushed the rename_framesexplorer branch from 8e02a7b to 2e19177 Compare August 2, 2022 20:39
ccordoba12
ccordoba12 reviewed Aug 2, 2022
View reviewed changes
setup.py Show resolved Hide resolved
spyder/api/plugins/enum.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/__init__.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/__init__.py Outdated Show resolved Hide resolved
@impact27 impact27 force-pushed the rename_framesexplorer branch from 1e3f2da to c7833a1 Compare August 3, 2022 05:04
ccordoba12
ccordoba12 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @impact27!

@ccordoba12 ccordoba12 merged commit 0cf98d6 into spyder-ide:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
None yet
Projects
None yet
Milestone
v6.0alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@impact27 @pep8speaks @ccordoba12