-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Preserve EOL characters when formatting text (Editor) #17555
Conversation
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-03-28 17:11:18 UTC |
This is necessary to fix formatting with eol's different than LF for Autopep8 and Yapf.
Also remove unused code for Python 2
…cordoba12/python-lsp-server.git external-deps/python-lsp-server subrepo: subdir: "external-deps/python-lsp-server" merged: "a38339494" upstream: origin: "https://github.com/ccordoba12/python-lsp-server.git" branch: "fix-yapf-crlf" commit: "a38339494" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Checked this locally and seems like this fixes #17143 👍
However, checking #16549 , the breakpoints still disappear with the changes here:
Should we remove this as a fix for #16549 ? Otherwise this LGTM 👍
If that's the case, then sure (I'll move that issue to the 5.3.1 milestone). I didn't bother to check because I thought almost surely this problem was connected to that issue, but thanks for double checking. Let me add one last commit to restore the subrepo to its default branch, then you can merge this one. |
…lsp/python-lsp-server.git external-deps/python-lsp-server subrepo: subdir: "external-deps/python-lsp-server" merged: "62cdac598" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "62cdac598" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596" [ci skip]
Description of Changes
python-lsp-server
(1.4.1+, already released) andpython-lsp-black
(1.2.0+, not released yet but working on it).Issue(s) Resolved
Fixes #17143
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: