Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throught -> through (misspelling) #17185

Closed
wants to merge 1 commit into from
Closed

throught -> through (misspelling) #17185

wants to merge 1 commit into from

Conversation

samiam2013
Copy link
Contributor

Description of Changes

corrected an English misspelling I noticed when installing Kite.

Issue(s) Resolved

Fixes # N/A

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Samiam2013

@dalthviz
Copy link
Member

dalthviz commented Jan 13, 2022

Hi @samiam2013 thank you for checking into this 👍 However the change needs to be done in the string inside the code rater than in the translations files (since these ones are regenerated from the string found in the source code). Just in case, the line to be changed is: https://github.com/spyder-ide/spyder/blob/5.x/spyder/plugins/completion/providers/kite/widgets/install.py#L213-L218

Also, note the base branch you are using, I would say that this will need to use as base branch 5.x so you should create a branch to push your changes with something like:

git checkout 5.x
git checkout -b fix_kite_text

And then when doing the PR on GitHub select as base 5.x

For more info related to the branches management you can check https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md#spyder-branches

@samiam2013
Copy link
Contributor Author

I'll open another request

@samiam2013 samiam2013 closed this Jan 13, 2022
@dalthviz
Copy link
Member

Note: Superseded by #17190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants