Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix autopep8 formatting and more failing tests #17106

Merged
merged 5 commits into from
Dec 28, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 27, 2021

Description of Changes

  • We were not using autopep8 for formatting when selected but black. That happened because we were not disabling the black PyLSP plugin correctly, so this one was taking precedence.
  • This also fixes more failing tests for Python 3.10 and the latest version of Yapf in our test suite.

Issue(s) Resolved

Fixes #17102
Fixes #17101
Fixes #17100

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.2.2 milestone Dec 27, 2021
This broke after the migration to the python-lsp-server
@pep8speaks
Copy link

pep8speaks commented Dec 27, 2021

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 769:80: E501 line too long (80 > 79 characters)

Comment last updated at 2021-12-27 22:33:10 UTC

@ccordoba12 ccordoba12 changed the title PR: Fix more failing tests PR: Fix autopep8 formatting and more failing tests Dec 27, 2021
@ccordoba12 ccordoba12 merged commit 863a6d4 into spyder-ide:5.x Dec 28, 2021
@ccordoba12 ccordoba12 deleted the more-test-fixes branch December 28, 2021 15:50
ccordoba12 added a commit that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants