Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Print last line of Pdb code #17089

Merged
merged 13 commits into from
Feb 16, 2022
Merged

PR: Print last line of Pdb code #17089

merged 13 commits into from
Feb 16, 2022

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Dec 24, 2021 •
edited by ccordoba12
Loading

Description of Changes

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Dec 24, 2021 •
edited
Loading

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-16 15:15:29 UTC

@impact27 impact27 changed the title PR: Print pdb out PR: Print last line of pdb code Dec 24, 2021
@ccordoba12 ccordoba12 changed the title PR: Print last line of pdb code PR: Print last line of Pdb code Dec 25, 2021
@ccordoba12 ccordoba12 added this to the v5.3.0 milestone Dec 25, 2021
ccordoba12
ccordoba12 reviewed Dec 25, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! I left some minor suggestions for you, otherwise looks good to me.

spyder/plugins/ipythonconsole/widgets/debugging.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/shell.py Outdated Show resolved Hide resolved
Quentin Peter added 2 commits December 28, 2021 00:20
add test
cd4a249
git subrepo clone --branch=print_pdb_out --force https://github.com/i…
5f97804 
…mpact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "56fd03428"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "print_pdb_out"
  commit:   "56fd03428"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@impact27
Copy link
Contributor Author

@ccordoba12 I added a return value to runcell and runfile following the same logic

Quentin Peter added 2 commits December 28, 2021 08:02
pep8
2bee0e9
git subrepo clone --branch=print_pdb_out --force https://github.com/i…
571c78e 
…mpact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "a4b177fec"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "print_pdb_out"
  commit:   "a4b177fec"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@ccordoba12
Copy link
Member

I added a return value to runcell

Nice! I think that's a great addition!

and runfile following the same logic

I'm not sure about that. I mean, runfile is our equivalent of python myfile.py, so I think we should preserve that you need to print something if you want to observe an output in that case.

git subrepo clone --branch=print_pdb_out --force https://github.com/i…
c063740 
…mpact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "00c4be4ea"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "print_pdb_out"
  commit:   "00c4be4ea"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@impact27
Copy link
Contributor Author

@ccordoba12 removed for runfile

Quentin Peter added 2 commits December 30, 2021 19:20
git subrepo clone --branch=print_pdb_out --force https://github.com/i…
aa10d29 
…mpact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "2db670b44"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "print_pdb_out"
  commit:   "2db670b44"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
git subrepo clone --branch=print_pdb_out --force https://github.com/i…
48a87f0 
…mpact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "bf7983a2e"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "print_pdb_out"
  commit:   "bf7983a2e"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@ccordoba12
Copy link
Member

@impact27, please rebase this one and resync our Spyder-kernels subrepo to see if tests are still passing.

impact27 and others added 3 commits February 16, 2022 12:09
@impact27
Merge remote-tracking branch 'upstream/5.x' into print_pdb_out
abee8dd
@impact27
git subrepo clone --branch=print_pdb_out --force https://github.com/i…
2071cf2 
…mpact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "b8d03879e9"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "print_pdb_out"
  commit:   "b8d03879e9"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
@ccordoba12
git subrepo clone (merge) --branch=2.x --force https://github.com/spy…
e55e428 
…der-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "8289aa80f"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "2.x"
  commit:   "8289aa80f"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"

[ci skip]
ccordoba12
ccordoba12 approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit a7d5f21 into spyder-ide:5.x Feb 16, 2022
ccordoba12 added a commit that referenced this pull request Feb 16, 2022
@ccordoba12
Merge from 5.x: PR #17089
a9c003f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
None yet
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@impact27 @pep8speaks @ccordoba12