Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change entry name for file completions to 'file' (Editor) #16210

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Aug 12, 2021

Description of Changes

This also scales the icon a bit to better match the size of the others.

Before

imagen

After

imagen

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Also, scale the icon a bit to better match the size of the others.
@ccordoba12 ccordoba12 added this to the v5.1.2 milestone Aug 12, 2021
@ccordoba12 ccordoba12 requested a review from isabela-pf August 12, 2021 20:52
@ccordoba12 ccordoba12 self-assigned this Aug 12, 2021
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 277:80: E501 line too long (126 > 79 characters)

@ccordoba12 ccordoba12 changed the title PR: Change entry name for file completions to 'file' (Completions) PR: Change entry name for file completions to 'file' (Editor) Aug 12, 2021
@isabela-pf
Copy link
Collaborator

Looks good to me! I really appreciate the change in description to be just file since they aren't actually new files (even though I know it was probably getting it from the icon's name). Thanks @ccordoba12!

@ccordoba12 ccordoba12 merged commit 94d139c into spyder-ide:5.x Aug 13, 2021
@ccordoba12 ccordoba12 deleted the improve-file-completions branch August 13, 2021 13:04
ccordoba12 added a commit that referenced this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants