Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Support Rich and Colorama in the IPython console #16095

Merged
merged 3 commits into from
Jul 28, 2021
Merged

PR: Support Rich and Colorama in the IPython console #16095

merged 3 commits into from
Jul 28, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 28, 2021 •
edited
Loading

Description of Changes

  • This makes the isatty attribute of the OutStream instance in our kernel to return True, which adds out of the box support for Rich and Colorama in our consoles.
  • It also makes os.get_terminal_size to return a proper value in our consoles.

Associated PRs:

Issue(s) Resolved

Fixes #1917.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12
git subrepo clone (merge) --branch=feat/isatty --force https://github…
1de9716 
….com/eendebakpt/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "0fce2342d"
upstream:
  origin:   "https://github.com/eendebakpt/spyder-kernels.git"
  branch:   "feat/isatty"
  commit:   "0fce2342d"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Jul 28, 2021
@ccordoba12 ccordoba12 self-assigned this Jul 28, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 28, 2021 •
edited
Loading

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 323:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated at 2021-07-28 17:26:13 UTC

@ccordoba12
git subrepo clone --branch=patch-terminal-size --force https://github…
839d461 
….com/ccordoba12/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "c262584b3"
upstream:
  origin:   "https://github.com/ccordoba12/spyder-kernels.git"
  branch:   "patch-terminal-size"
  commit:   "c262584b3"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@ccordoba12
git subrepo clone (merge) --branch=2.x --force https://github.com/spy…
558a21a 
…der-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "786edcae4"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "2.x"
  commit:   "786edcae4"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"

[ci skip]
@ccordoba12 ccordoba12 merged commit f44cb72 into spyder-ide:5.x Jul 28, 2021
@ccordoba12 ccordoba12 deleted the support-colorama-and-rich branch July 28, 2021 17:27
ccordoba12 added a commit that referenced this pull request Jul 28, 2021
@ccordoba12
Merge from 5.x: PR #16095
712cccf 
Fixes #1917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ccordoba12 ccordoba12

Labels
None yet
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @pep8speaks