Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add option to disable tooltip on toolbars when creating actions #13398

Merged

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jul 27, 2020

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #13378

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca self-assigned this Jul 27, 2020
@goanpeca goanpeca requested a review from ccordoba12 July 27, 2020 16:52
@goanpeca goanpeca added this to the Sprint July milestone Jul 27, 2020
@goanpeca goanpeca changed the title Add option to disable tooltip on toolbars when creating actions PR: Add option to disable tooltip on toolbars when creating actions Jul 27, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca for your fast response to solve the issues I reported on #13378. One quick question: does the ToolTipFilter class you added disable tooltips for all actions in toolbars?

If that's the case, I'd like to have a bit more flexibility by deciding when to show or not tooltips for actions. In some cases we need to show them (for example for the regular expressions button in Find); and we don't in others (e.g. for the Search button in Find too).

@goanpeca
Copy link
Member Author

goanpeca commented Jul 29, 2020

Thanks @goanpeca for your fast response to solve the issues I reported on #13378. One quick question: does the ToolTipFilter class you added disable tooltips for all actions in toolbars?

@ccordoba12 the filter is only applied to actions that don't have icon_text (that is what the icon_text option for creating an action is) In this example the search action defines a text (shown in the menu) and icon_text = Search

find

@ccordoba12
Copy link
Member

the filter is only applied to actions that don't have icon_text (that is what the icon_text option for creating an action is)

Ok, noted. That's what I needed to know. Thanks for the clarification!

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca!

@ccordoba12 ccordoba12 merged commit 963b74a into spyder-ide:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some problems with the Find plugin in master
2 participants