Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migrate Console Plugin to the new API #12438

Merged
merged 1 commit into from
May 27, 2020
Merged

PR: Migrate Console Plugin to the new API #12438

merged 1 commit into from
May 27, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Apr 22, 2020 •
edited
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #12727
Depends on #11741

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca self-assigned this Apr 22, 2020
@goanpeca goanpeca added this to the Sprint April milestone Apr 22, 2020
@pep8speaks
Copy link

pep8speaks commented Apr 22, 2020 •
edited
Loading

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-27 18:23:54 UTC

@goanpeca goanpeca force-pushed the enh/api-console branch 7 times, most recently from 8b7d3ba to c5abdd7 Compare April 23, 2020 00:36
@goanpeca goanpeca requested review from ccordoba12 and dalthviz April 30, 2020 16:17
@ccordoba12 ccordoba12 modified the milestones: Sprint April, Sprint May May 2, 2020
@goanpeca goanpeca force-pushed the enh/api-console branch 2 times, most recently from 03f3e6a to e7ffb48 Compare May 13, 2020 17:47
@goanpeca goanpeca requested review from ccordoba12 and removed request for ccordoba12 and dalthviz May 13, 2020 20:51
@goanpeca goanpeca force-pushed the enh/api-console branch 4 times, most recently from 5cefc14 to 1cccca0 Compare May 21, 2020 21:08
@goanpeca goanpeca force-pushed the enh/api-console branch 4 times, most recently from a0b85ba to 64dbacf Compare May 25, 2020 17:02
ccordoba12
ccordoba12 reviewed May 25, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goanpeca, I left an initial review for you.

spyder/plugins/console/plugin.py Outdated Show resolved Hide resolved
spyder/app/mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/console/api.py Outdated Show resolved Hide resolved
spyder/plugins/console/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/console/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/shell.py Show resolved Hide resolved
spyder/plugins/console/widgets/shell.py Show resolved Hide resolved
spyder/widgets/mixins.py Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Migrate Console Plugin to new API PR: Migrate Console Plugin to the new API May 25, 2020
@goanpeca goanpeca force-pushed the enh/api-console branch 2 times, most recently from a469213 to 04def07 Compare May 26, 2020 02:34
@goanpeca goanpeca requested a review from ccordoba12 May 26, 2020 02:34
@goanpeca
Copy link
Member Author

Hi @ccordoba12 addressed all the issues (except a couple I think) and made the rebase.

@goanpeca goanpeca force-pushed the enh/api-console branch 2 times, most recently from 5111f67 to a08548d Compare May 26, 2020 17:29
ccordoba12
ccordoba12 reviewed May 26, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another (very minor) review for you @goanpeca!

spyder/plugins/console/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/console/plugin.py Show resolved Hide resolved
spyder/plugins/console/widgets/console.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/internalshell.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/internalshell.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/shell.py Outdated Show resolved Hide resolved
spyder/plugins/console/widgets/shell.py Outdated Show resolved Hide resolved
spyder/widgets/mixins.py Outdated Show resolved Hide resolved
@goanpeca goanpeca requested a review from ccordoba12 May 27, 2020 01:08
ccordoba12
ccordoba12 reviewed May 27, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked most functionality and it's working fine. I only left a minor comment about the wrong tabified behavior of the internal console itself.

spyder/app/mainwindow.py Outdated Show resolved Hide resolved
@goanpeca
Copy link
Member Author

I checked most functionality and it's working fine. I only left a minor comment about the wrong tabified behavior of the internal console itself.

Fixed!

Thanks for the review!

ccordoba12
ccordoba12 approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca! Great work here!

@ccordoba12 ccordoba12 merged commit 2e8f2e6 into spyder-ide:master May 27, 2020
@goanpeca goanpeca deleted the enh/api-console branch May 27, 2020 18:52
@ccordoba12 ccordoba12 mentioned this pull request Jun 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@goanpeca goanpeca

Labels
None yet
Projects
None yet
Milestone
Sprint May
Development

Successfully merging this pull request may close these issues.

Move Internal Console plugin to new API
3 participants
@goanpeca @pep8speaks @ccordoba12