Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Move Breakpoints Plugin to new API #12324

Merged
merged 1 commit into from
Jun 10, 2020
Merged

PR: Move Breakpoints Plugin to new API #12324

merged 1 commit into from
Jun 10, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Apr 14, 2020 •
edited
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

image

Issue(s) Resolved

Fixes #12325
Depends on #11741

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@pep8speaks
Copy link

pep8speaks commented Apr 14, 2020 •
edited
Loading

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-10 20:50:49 UTC

@goanpeca goanpeca force-pushed the enh/api-breakpoints branch 4 times, most recently from dc05959 to 04707de Compare April 17, 2020 14:20
@goanpeca goanpeca force-pushed the enh/api-breakpoints branch 4 times, most recently from c628647 to cad175e Compare April 23, 2020 00:18
@goanpeca goanpeca added this to the Sprint April milestone Apr 23, 2020
@goanpeca goanpeca self-assigned this Apr 23, 2020
@goanpeca goanpeca changed the title PR: Move breakpoints to new API PR: Move Breakpoints Plugin to new API Apr 23, 2020
@goanpeca goanpeca requested review from steff456 and ccordoba12 April 30, 2020 16:17
@ccordoba12 ccordoba12 modified the milestones: Sprint April, Sprint May May 2, 2020
@goanpeca goanpeca force-pushed the enh/api-breakpoints branch from cad175e to 0b9634b Compare May 14, 2020 20:17
@goanpeca goanpeca force-pushed the enh/api-breakpoints branch 2 times, most recently from 72c7433 to 0e8329a Compare May 26, 2020 13:46
@goanpeca goanpeca requested review from ccordoba12 and removed request for ccordoba12 and steff456 May 26, 2020 13:58
@goanpeca goanpeca force-pushed the enh/api-breakpoints branch from 2dd198f to 0c9abbf Compare May 26, 2020 14:32
@goanpeca
Copy link
Member Author

This one is ready for review @ccordoba12

@goanpeca goanpeca force-pushed the enh/api-breakpoints branch 2 times, most recently from 47e848a to 3568453 Compare May 27, 2020 20:02
@ccordoba12 ccordoba12 modified the milestones: Sprint May, Sprint June Jun 1, 2020
@goanpeca goanpeca force-pushed the enh/api-breakpoints branch from 3568453 to c76fc6e Compare June 10, 2020 15:06
@goanpeca goanpeca removed the request for review from ccordoba12 June 10, 2020 15:06
@goanpeca goanpeca requested a review from dalthviz June 10, 2020 15:06
@goanpeca goanpeca force-pushed the enh/api-breakpoints branch from c76fc6e to 0916178 Compare June 10, 2020 15:07
@goanpeca
Copy link
Member Author

Hi @dalthviz this one is also ready to check when you have some time. Thanks!

ccordoba12
ccordoba12 reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good @goanpeca! I only left some small comments.

spyder/plugins/breakpoints/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/breakpoints/widgets/main_widget.py Outdated Show resolved Hide resolved
dalthviz
dalthviz previously approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After an initial test seems like the actions are working as expected 👍

@goanpeca goanpeca requested a review from ccordoba12 June 10, 2020 18:56
@goanpeca
Copy link
Member Author

goanpeca commented Jun 10, 2020 •
edited
Loading

Thanks @dalthviz!

@ccordoba12 fixed the comments. If you agree with the PR please do not merge until I squash into a single commit. Thanks!

@ccordoba12
Copy link
Member

If you agree with the PR please do not merge until I squash into a single commit

I agree with your changes. Please squash them now so I can merge this one.

@goanpeca goanpeca force-pushed the enh/api-breakpoints branch from f43182d to a0b43fa Compare June 10, 2020 20:50
@goanpeca
Copy link
Member Author

Done

ccordoba12
ccordoba12 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca!

@ccordoba12 ccordoba12 merged commit 667fa7f into spyder-ide:master Jun 10, 2020
@goanpeca goanpeca deleted the enh/api-breakpoints branch June 10, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@dalthviz dalthviz dalthviz left review comments

Assignees

@goanpeca goanpeca

Labels
None yet
Projects
None yet
Milestone
Sprint June
Development

Successfully merging this pull request may close these issues.

Move Breakpoints plugin to use new API
4 participants
@goanpeca @pep8speaks @ccordoba12 @dalthviz