Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Expose package version in SpyderShell #408

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

impact27
Copy link
Contributor

Expose spyder kernels version for checking from the frontend

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impact27, besides my tiny suggestion below I'd like to ask you: the improvements based on this PR are meant for master of both Spyder-kernels and Spyder, right?

spyder_kernels/console/shell.py Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title spyder kernels version Expose package version in SpyderShell Aug 18, 2022
@ccordoba12 ccordoba12 changed the title Expose package version in SpyderShell PR: Expose package version in SpyderShell Aug 18, 2022
@impact27
Copy link
Contributor Author

@impact27, besides my tiny suggestion below I'd like to ask you: the improvements based on this PR are meant for master of both Spyder-kernels and Spyder, right?

Yes the corresponding PR is spyder-ide/spyder#19074, opened on master

@ccordoba12 ccordoba12 added this to the v3.0.0b1 milestone Aug 18, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit 1d7b434 into spyder-ide:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants