Skip to content

Commit

Permalink
Add pip check to release and pip & twine check to CIs
Browse files Browse the repository at this point in the history
  • Loading branch information
CAM-Gerlach committed Nov 8, 2021
1 parent b8b939c commit 38f0fe0
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
CI: 'True'
PYTHON_VERSION: ${{ matrix.python-version }}
USE_CONDA: ${{ matrix.use-conda }}
SKIP_PIP_CHECK: ${{ matrix.skip-pip-check }}
PYQT5_VERSION: ${{ matrix.pyqt5-version }}
PYQT6_VERSION: ${{ matrix.pyqt6-version }}
PYSIDE2_VERSION: ${{ matrix.pyside2-version }}
Expand All @@ -43,6 +44,7 @@ jobs:
special-invocation: 'xvfb-run --auto-servernum '
- python-version: '3.6'
use-conda: 'No'
skip-pip-check: 'true' # Pytest packaging issue on Python 3.6 defaults channel
pyside2-version: 5.12.0 # 5.12.1-5.12.6 fails on collection/segfaults on patch test
- os: ubuntu-latest
python-version: '3.6'
Expand Down Expand Up @@ -104,6 +106,5 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd qtpy # Switch to test working dir per non-src-layout hack
python -m pip install --upgrade coveralls
cat qtpy_basedir.txt
python -b -X dev -m coveralls --service=github --rcfile="../.coveragerc" --basedir="$(cat qtpy_basedir.txt)"
pipx run coveralls --service=github --rcfile="../.coveragerc" --basedir="$(cat qtpy_basedir.txt)"
7 changes: 6 additions & 1 deletion .github/workflows/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fi

# Build wheel of package
git clean -xdf -e *.coverage
pip install --upgrade build
python -m pip install --upgrade build
python -bb -X dev -W error -W ignore:::pyparsing -m build

# Install package from built wheel
Expand All @@ -59,3 +59,8 @@ python -I -bb -X dev -W error -m pytest --cov-config ../.coveragerc --cov-append
# Save QtPy base dir for coverage
python -c "from pathlib import Path; import qtpy; print(Path(qtpy.__file__).parent.parent.resolve().as_posix())" > qtpy_basedir.txt
cat qtpy_basedir.txt
cd ..

# Check package and environment
pipx run twine check --strict dist/*
pip check -v || ${SKIP_PIP_CHECK:-false}
2 changes: 2 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ To release a new version of QtPy on PyPI:

* `python -bb -X dev -W error -m pip install dist/*.whl`

* `pip check`

* `python -bb -X dev -W error -m pytest qtpy/tests`

* `python -bb -X dev -W error -m pip install -e .`
Expand Down

0 comments on commit 38f0fe0

Please sign in to comment.