Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-4696: Updated doc with new vertax glue endpoint #3049

Conversation

vol4onok
Copy link
Contributor

@vol4onok vol4onok commented Feb 7, 2025

PR labels

When the PR is ready for review, add a TW review needed label. This lets us keep track of PRs that need to be merged and merge them in time.

PR Description

Describe the context for your changes and the changes you've made.

Tickets

https://spryker.atlassian.net/browse/ACP-4696

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@vol4onok
Copy link
Contributor Author

vol4onok commented Feb 7, 2025

@vol4onok vol4onok added the small changes PR contains small changes, like typo fixes label Feb 7, 2025
stereomon
stereomon previously approved these changes Feb 10, 2025
{
return [
//....
new TaxValidateIdResourceRoutePlugin(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
}
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the criteria of success?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be the reply?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@vol4onok vol4onok added the TW review needed PR needs Technical writer's review label Feb 13, 2025
template: howto-guide-template
---

To [install Taxamo](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/install-vertex.html), you need to update [spryker/tax-app:0.4.0](https://github.com/spryker/tax-app-rest-api) and install the [spryker/tax-app-rest-api](https://github.com/spryker/tax-app-rest-api) module first.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are the same.
Provide commands to install and update the modules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -37,3 +37,4 @@ To install Vertex, integrate the ACP connector module and the Vertex app:

1. [Integrate ACP connector module for tax calculation](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-acp-connector-module-for-tax-calculation.html)
2. [Integrate the Vertex app](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-vertex-app.html)
3. [Integrate the Taxamo app](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-taxamo-app.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not. we have one configuration for the Vertex. but if we don't create an integration for Taxamo we'll have a configuration for it (it's optional) but it won't be possible to use from the SCOSS side. in this case it's require for vertax integration

@andriitserkovnyi andriitserkovnyi merged commit 270e499 into master Feb 18, 2025
6 of 8 checks passed
@andriitserkovnyi andriitserkovnyi deleted the feature/acp-4696/master-taxamo-tax-id-validation-endpoint branch February 18, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small changes PR contains small changes, like typo fixes TW review needed PR needs Technical writer's review
Development

Successfully merging this pull request may close these issues.

3 participants