-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP-4696: Updated doc with new vertax glue endpoint #3049
ACP-4696: Updated doc with new vertax glue endpoint #3049
Conversation
{ | ||
return [ | ||
//.... | ||
new TaxValidateIdResourceRoutePlugin(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the criteria of success?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be possible to validate taxId via Glue https://github.com/spryker/spryker-docs/pull/3049/files#diff-56d3ddba26af2334484182a6fb822bb7944196e7f6645114edad9ba00d5a027fR65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should be the reply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
template: howto-guide-template | ||
--- | ||
|
||
To [install Taxamo](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/install-vertex.html), you need to update [spryker/tax-app:0.4.0](https://github.com/spryker/tax-app-rest-api) and install the [spryker/tax-app-rest-api](https://github.com/spryker/tax-app-rest-api) module first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links are the same.
Provide commands to install and update the modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
...02410.0/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-taxamo-app.md
Outdated
Show resolved
Hide resolved
…nt' of https://github.com/spryker/spryker-docs into feature/acp-4696/master-taxamo-tax-id-validation-endpoint
@@ -37,3 +37,4 @@ To install Vertex, integrate the ACP connector module and the Vertex app: | |||
|
|||
1. [Integrate ACP connector module for tax calculation](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-acp-connector-module-for-tax-calculation.html) | |||
2. [Integrate the Vertex app](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-vertex-app.html) | |||
3. [Integrate the Taxamo app](/docs/pbc/all/tax-management/{{page.version}}/base-shop/third-party-integrations/vertex/install-vertex/integrate-the-taxamo-app.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not. we have one configuration for the Vertex. but if we don't create an integration for Taxamo we'll have a configuration for it (it's optional) but it won't be possible to use from the SCOSS side. in this case it's require for vertax integration
PR labels
When the PR is ready for review, add a TW review needed label. This lets us keep track of PRs that need to be merged and merge them in time.
PR Description
Describe the context for your changes and the changes you've made.
Tickets
https://spryker.atlassian.net/browse/ACP-4696
Checklist