Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-773: Stripe documentation mvp #2440

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

danielsantos-spryker
Copy link
Contributor

@danielsantos-spryker danielsantos-spryker commented Jan 11, 2024

PR Description

TBD

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@danielsantos-spryker danielsantos-spryker added the in progress PR is not ready for review label Jan 11, 2024
matweew
matweew previously approved these changes Jan 11, 2024
Copy link
Collaborator

@matweew matweew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From technical point of view it's good.

@danielsantos-spryker danielsantos-spryker marked this pull request as ready for review January 12, 2024 08:56
@danielsantos-spryker danielsantos-spryker added TW review needed PR needs Technical writer's review and removed in progress PR is not ready for review labels Jan 12, 2024
stereomon
stereomon previously approved these changes Jan 12, 2024
@lenadoc lenadoc dismissed stale reviews from stereomon and matweew via e4e76b9 January 15, 2024 17:52
Before integrating Stripe, ensure the following prerequisites are met:

- Make sure your project is ACP-enabled. See [App Composition Platform installation](/docs/acp/user/app-composition-platform-installation.html) for details.
- Make sure you have a Stripe connected account to Spryker platform, if you are unsure how to do it, please contact Spryker support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean here? Do you mean that they should have Stipe installed (by following the docs/pbc/all/payment-service-provider/202311.0/base-shop/third-party-integrations/stripe/install-stripe.md guide)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part might not be needed, you wouldn't be able to configure without install first and to install your project would have to be ACP-enabled

Copy link
Contributor Author

@danielsantos-spryker danielsantos-spryker Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make sure you have a Stripe connected account to Spryker platform, if you are unsure how to do it, please contact Spryker support.

For configuration you will need an account ID from Stripe, but it's not just any account it need to be a connected account.

2. In the top right corner of the Stripe app details page, click **Configure**.
3. On the Stripe app details page, fill in the account ID field in the **Configuration** section.
4. Select **Stripe Environment Mode**.
5. Enter your *Shop Name*. This name will be displayed on **Payment** page as a merchant label for whom to pay:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please upload the screenshot for the Stripe configuration page in the back office? Because on https://backoffice.de.aop-suite-staging.demo-spryker.com/ I cannot see the Shop Name filed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-16 at 10 19 44

Please check

@lenadoc lenadoc added new PR contains a new document and removed TW review needed PR needs Technical writer's review labels Jan 16, 2024
@lenadoc lenadoc merged commit 63a3942 into master Jan 17, 2024
13 checks passed
@lenadoc lenadoc deleted the feature/acp-773-stripe-documentation-mvp branch January 17, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new PR contains a new document
Development

Successfully merging this pull request may close these issues.

4 participants