Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added reserved variable sub-section. Plus, removed deprecated text. #1960

Merged
merged 10 commits into from
Jul 5, 2023
Merged

added reserved variable sub-section. Plus, removed deprecated text. #1960

merged 10 commits into from
Jul 5, 2023

Conversation

romansprykee
Copy link
Collaborator

@romansprykee romansprykee commented Jul 3, 2023 •
edited
Loading

PR Description

TBD

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@romansprykee romansprykee self-assigned this Jul 3, 2023
@romansprykee romansprykee requested a review from tvaleriy July 3, 2023 09:54
@romansprykee romansprykee added the updated PR contains meaningful changes to some document label Jul 3, 2023
AymenSegni
AymenSegni reviewed Jul 3, 2023
View reviewed changes
Copy link

@AymenSegni AymenSegni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's have an additional warning about the change in the SPRYKER_ vars, and the access will be denied to these variables, many customers they already use the variables and they will suddenly has no access to the vars

@romansprykee
Copy link
Collaborator Author

@AymenSegni I added a comment in the warning block regarding existing variables that are using restricted names.

tvaleriy
tvaleriy previously approved these changes Jul 3, 2023
View reviewed changes
hatemzidi-pro
hatemzidi-pro approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@hatemzidi-pro hatemzidi-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenadoc lenadoc merged commit 2674753 into master Jul 5, 2023
@lenadoc lenadoc deleted the evm-change-branch branch July 5, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AymenSegni AymenSegni AymenSegni approved these changes

@lenadoc lenadoc lenadoc approved these changes

@hatemzidi-pro hatemzidi-pro hatemzidi-pro approved these changes

@tvaleriy tvaleriy tvaleriy left review comments

@VadymSachenko VadymSachenko Awaiting requested review from VadymSachenko

@AlexSlawinski AlexSlawinski Awaiting requested review from AlexSlawinski

@andriitserkovnyi andriitserkovnyi Awaiting requested review from andriitserkovnyi

Assignees

@romansprykee romansprykee

Labels
updated PR contains meaningful changes to some document
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romansprykee @tvaleriy @AymenSegni @lenadoc @hatemzidi-pro