Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app-composition-platform-installation.md #1871

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Update app-composition-platform-installation.md #1871

merged 11 commits into from
Aug 3, 2023

Conversation

jeremyfourna
Copy link
Contributor

Remove the fixed list of app that will make the page not dynamic.

TBD

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@jeremyfourna
Update app-composition-platform-installation.md
875f2b8 
Remove the fixed list of app that will make the page not dynamic.
@jeremyfourna jeremyfourna added the TW review needed PR needs Technical writer's review label May 25, 2023
@jeremyfourna jeremyfourna self-assigned this May 25, 2023
thomas-schwaier-spryker
thomas-schwaier-spryker reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@thomas-schwaier-spryker thomas-schwaier-spryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will keep that list for now until we are able inject a dynamic list into that. Otherwise users will have to search for them and it will be (super) hard to find if you do not know what u are looking for.

@VadymSachenko VadymSachenko added small changes PR contains small changes, like typo fixes ready for merge The PR can be merged and removed TW review needed PR needs Technical writer's review labels Jul 31, 2023
@VadymSachenko VadymSachenko requested a review from a team as a code owner August 2, 2023 13:35
@VadymSachenko VadymSachenko merged commit c52a7f3 into master Aug 3, 2023
@VadymSachenko VadymSachenko deleted the jeremyfourna-patch-4 branch August 3, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-schwaier-spryker thomas-schwaier-spryker thomas-schwaier-spryker left review comments

@VadymSachenko VadymSachenko VadymSachenko approved these changes

@lenadoc lenadoc Awaiting requested review from lenadoc

@AlexSlawinski AlexSlawinski Awaiting requested review from AlexSlawinski

@andriitserkovnyi andriitserkovnyi Awaiting requested review from andriitserkovnyi

Assignees

@jeremyfourna jeremyfourna

Labels
ready for merge The PR can be merged small changes PR contains small changes, like typo fixes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyfourna @VadymSachenko @thomas-schwaier-spryker