Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in TM Terminal 10.6.1 from CDT to fix shell OSC customizations #1303

Closed
space88man opened this issue Jul 24, 2024 · 2 comments
Closed
Assignees
Labels
for: eclipse something that is specific for Eclipse type: enhancement

Comments

@space88man
Copy link

space88man commented Jul 24, 2024

Expected Behavior
/bin/bash /bin/zsh work in Terminal when the OS provider has used OSC escape sequences to customize the shell prompt and other behaviour

CDT TM Terminal has fixed a long outstanding bug in shells (bash / zsh) when the customizations in /etc/profile.d/*.sh use OSC escape sequences ending in ESC-\ (backslash). Previously it only handled OSC escape sequences ending in BEL.

eclipse-cdt/cdt#831 particularly eclipse-cdt/cdt#831 (comment)

Current Behavior
On Fedora / macos: using /bin/bash /bin/zsh as the shell command results in no UI (actually the shell is running but the terminal display is b0rked)

Context
No shell UI in Fedora when using /bin/bash or /bin/zsh (/bin/fish /bin/ksh work - presumably they are not using OSC sequences ending in ESC-\)

Affects 4.24.0 (this might have just missed the CDT 10.6.1 p2 update).

@martinlippert
Copy link
Member

Thanks for the pointer here, makes sense to grab the latest from the CDT update sites here. Fixed with 4c67594, now waiting for the CI build to produce snapshot distribution builds for it.

@martinlippert
Copy link
Member

Latest nightly builds include the updated terminal feature from CDT 11.6.1: https://cdn.spring.io/spring-tools/snapshot/STS4/nightly-distributions.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants