GH-1409: do not compute completion proposals when cursor is on attrib…

…ute name instead of value
spring-projects · Nov 15, 2024 · 0b90be1 · 0b90be1
1 parent d43f16a
commit 0b90be1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...ingframework/ide/vscode/boot/java/annotations/AnnotationAttributeCompletionProcessor.java b/...ingframework/ide/vscode/boot/java/annotations/AnnotationAttributeCompletionProcessor.java
@@ -77,6 +77,7 @@ else if (node instanceof Name && node.getParent() instanceof Annotation
 			}
 			// case: @Qualifier(value=<*>)
 			else if (node instanceof Name && node.getParent() instanceof MemberValuePair
+					&& ((MemberValuePair)node.getParent()).getName() != node
 					&& completionProviders.containsKey(((MemberValuePair)node.getParent()).getName().toString())) {
 				String attributeName = ((MemberValuePair)node.getParent()).getName().toString();
 				computeProposalsForSimpleName(project, node, attributeName, completions, offset, doc);

diff --git a/.../org/springframework/ide/vscode/boot/java/beans/test/DependsOnCompletionProviderTest.java b/.../org/springframework/ide/vscode/boot/java/beans/test/DependsOnCompletionProviderTest.java
@@ -169,6 +169,11 @@ public void testDependsOnCompletionOutsideOfAnnotation2() throws Exception {
 		assertCompletions("@DependsOn<*>(\"XXX\")", 0, null);
 	}
 
+	@Test
+	public void testDependsOnCompletionInsideOfAttributeName() throws Exception {
+		assertCompletions("@DependsOn(<*>value=\"bean1\")", 0, null);
+	}
+
 	@Test
 	public void testDependsOnCompletionInsideOfQuotesWithPrefixAndReplacedPostfix() throws Exception {
 		assertCompletions("@DependsOn(\"be<*>xxx\")", 2, "@DependsOn(\"bean1<*>\")");