Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Spring WS BOM #1290

Closed
wilkinsona opened this issue Nov 14, 2022 · 3 comments
Closed

Introduce Spring WS BOM #1290

wilkinsona opened this issue Nov 14, 2022 · 3 comments
Assignees
Milestone

Comments

@wilkinsona
Copy link
Member

The bom has been configured with a parent:

<parent>
<groupId>org.springframework.ws</groupId>
<artifactId>spring-ws</artifactId>
<version>4.0.0-SNAPSHOT</version>
</parent>

This parent contains dependency management:

spring-ws/pom.xml

Lines 131 to 166 in b67a03d

<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-framework-bom</artifactId>
<version>${spring.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.springframework.security</groupId>
<artifactId>spring-security-bom</artifactId>
<version>${spring-security.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-bom</artifactId>
<version>${jetty.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

As a result, the bom's managing the versions of Spring Framework, Spring Security, JUnit, and Jetty. It should only manage the versions of Spring Web Service's own modules.

@gregturn gregturn changed the title Bom manages dependencies from other projects Introduce Spring WS BOM Nov 14, 2022
@gregturn
Copy link
Contributor

Based on the complexity arising and being this late, I'm going to withdraw the BOM from Spring WS 4.0 and revisit it later @wilkinsona.

@gregturn gregturn self-assigned this Nov 14, 2022
gregturn added a commit that referenced this issue Nov 14, 2022
Due to this pulling in other project BOMs, we will delay introducing a Spring WS BOM until a later release.

Resolves #1291.

Related: #1290.
@mdeinum
Copy link
Contributor

mdeinum commented Nov 15, 2022

@gregturn anything I can do to help out with this?

@gregturn
Copy link
Contributor

gregturn commented Jan 5, 2023

Thanks @mdeinum. I worked through this slightly modified setup and ran it by a couple teammates for review. This lets us accomplish having the BOM without having to spin up a separate project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants