Support authentication on global region for AWS IAM (close #758) #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amuerte Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Amuerte Thank you for signing the Contributor License Agreement! |
Amuerte
changed the title
|
Close #758 |
Amuerte
force-pushed
the
feat/aws-iam-sign-global
branch
from
7585758 to
7e14733
Compare
Amuerte
force-pushed
the
feat/aws-iam-sign-global
branch
from
7e14733 to
d78dd13
Compare
mp911de
requested changes
Mar 17, 2023
| /** | ||
| * Build a new {@link AwsIamAuthenticationOptions} instance. | ||
| * @return a new {@link AwsIamAuthenticationOptions}. | ||
| */ | ||
| public AwsIamAuthenticationOptions build() { | ||
|
|
||
| Assert.state(this.credentialsProvider != null, "Credentials or CredentialProvider must not be null"); | ||
| if (useGlobalEndpoint) { |
There was a problem hiding this comment.
If using the global endpoint is merely a matter of providing the right Region, why don't you just call regionProvider(() -> Region.US_EAST_1)?
There was a problem hiding this comment.
mmh good point you raised here 😅 . By looking more in details, we are blocked because we are using spring-cloud-vault-config to instantiate the AwsIamAuthentication, and it does not offer a way to configure the region.
I will create an issue and a PR there. Sorry for that.
mp911de
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables one to perform AWS IAM authentication when the Vault instance is configured on the Global STS endpoint (us-east-1) and the application is deployed on another region.