Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support ServerGenerateOneTimeTokenRequestResolver #16489

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

franticticktick
Copy link
Contributor

Closes gh-16488

@jzheaux
Copy link
Contributor

jzheaux commented Jan 27, 2025

Hi, @franticticktick. This could be reasonable to add. Can you explain more about your use case so that we are on the same page as to the problem you are wanting to solve?

@jzheaux
Copy link
Contributor

jzheaux commented Jan 27, 2025

Please disregard that message, I wasn't aware that #16297 had been merged.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @franticticktick! I left my feedback inline.

@jzheaux jzheaux self-assigned this Feb 3, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 3, 2025
@jzheaux jzheaux added this to the 6.5.0-M2 milestone Feb 3, 2025
@franticticktick
Copy link
Contributor Author

Hi @jzheaux, thnaks for your feedback. I modified the OneTimeTokenLoginSpecTests according to the pattern that @rwinch made. There is only one point that we need to pay attention to, I noted it in your comments. Could you please review the changes?

@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2025

Great, @franticticktick. Sorry that this specific request was unclear: Will you please ensure that the concurrency repair is in a separate commit that precedes your feature enhancement? This will make it easier to compare that change to Rob's change and also make it easier to backport, should that become necessary.

@franticticktick
Copy link
Contributor Author

I didn't look at your comment carefully, sorry please. I made two commits and also removed the unstable expiration check as @rwinch did. I made similar changes to ServerOneTimeTokenLoginDslTests.

@jzheaux jzheaux merged commit 9676739 into spring-projects:main Feb 5, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2025

Thanks, @franticticktick! This is now merged into main. And thanks again for separating the concurrency fix into a separate commit; I realize we usually ask for commits to be squashed and that was extra work for you to tease them apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support ServerGenerateOneTimeTokenRequestResolver
3 participants