-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support ServerGenerateOneTimeTokenRequestResolver #16489
Conversation
Hi, @franticticktick. This could be reasonable to add. Can you explain more about your use case so that we are on the same page as to the problem you are wanting to solve? |
Please disregard that message, I wasn't aware that #16297 had been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @franticticktick! I left my feedback inline.
...src/test/java/org/springframework/security/config/web/server/OneTimeTokenLoginSpecTests.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/springframework/security/config/web/server/OneTimeTokenLoginSpecTests.java
Outdated
Show resolved
Hide resolved
...est/kotlin/org/springframework/security/config/web/server/ServerOneTimeTokenLoginDslTests.kt
Outdated
Show resolved
Hide resolved
...rg/springframework/security/web/server/authentication/ott/GenerateOneTimeTokenWebFilter.java
Outdated
Show resolved
Hide resolved
...ity/web/server/authentication/ott/DefaultServerGenerateOneTimeTokenRequestResolverTests.java
Outdated
Show resolved
Hide resolved
...rg/springframework/security/web/server/authentication/ott/GenerateOneTimeTokenWebFilter.java
Show resolved
Hide resolved
93d7dbd
to
1015622
Compare
Great, @franticticktick. Sorry that this specific request was unclear: Will you please ensure that the concurrency repair is in a separate commit that precedes your feature enhancement? This will make it easier to compare that change to Rob's change and also make it easier to backport, should that become necessary. |
Closes spring-projectsgh-16488 Signed-off-by: Max Batischev <[email protected]>
1015622
to
0002aed
Compare
…c variable Signed-off-by: Max Batischev <[email protected]>
0002aed
to
0ee71ad
Compare
I didn't look at your comment carefully, sorry please. I made two commits and also removed the unstable expiration check as @rwinch did. I made similar changes to |
Thanks, @franticticktick! This is now merged into |
Closes gh-16488