-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation for the default uri client request observation metric #34116
Clarify documentation for the default uri client request observation metric #34116
Conversation
@Mattias-Sehlstedt Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Thanks for your PR! Just realized that you didn't sign the CLA yet @Mattias-Sehlstedt, I'll put this issue back in triage until this is done. |
I keep getting "Reauthorization required" when trying to sign the agreement, and I cannot see it as a know issue on the pivotal page (https://cla.pivotal.io/about). I have tried revoking the access and then enabling it again but the issue persists. Could this be considered an "Obvious fix", or should I be in contact with Pivotal and ask them about it? |
Thanks for trying; I'll see what I can do. |
…to describe what parts that are removed from the template Signed-off-by: Mattias-Sehlstedt <[email protected]>
07bc906
to
7ea938b
Compare
@Mattias-Sehlstedt Thank you for signing the Contributor License Agreement! |
Thanks @Mattias-Sehlstedt for your contribution! |
Thanks for the quick feedback and assistance @bclozel, makes it a very pleasant experience to contribute to open source 👍 |
Change the description for the uri client request observation metric to clarify that only the protocol, host and port parts are removed from the template with the default observability convention.
Adds tests to illustrate that it is intentional that the query parameters are kept as part of the template.
closes #34107