Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for the default uri client request observation metric #34116

Conversation

Mattias-Sehlstedt
Copy link
Contributor

Change the description for the uri client request observation metric to clarify that only the protocol, host and port parts are removed from the template with the default observability convention.

Adds tests to illustrate that it is intentional that the query parameters are kept as part of the template.

closes #34107

@pivotal-cla
Copy link

@Mattias-Sehlstedt Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 18, 2024
@bclozel bclozel self-assigned this Dec 18, 2024
@bclozel bclozel added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 18, 2024
@bclozel bclozel modified the milestone: 6.2.2 Dec 18, 2024
@bclozel bclozel added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 18, 2024
@bclozel
Copy link
Member

bclozel commented Dec 18, 2024

Thanks for your PR! Just realized that you didn't sign the CLA yet @Mattias-Sehlstedt, I'll put this issue back in triage until this is done.

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Dec 18, 2024
@Mattias-Sehlstedt
Copy link
Contributor Author

I keep getting "Reauthorization required" when trying to sign the agreement, and I cannot see it as a know issue on the pivotal page (https://cla.pivotal.io/about). I have tried revoking the access and then enabling it again but the issue persists. Could this be considered an "Obvious fix", or should I be in contact with Pivotal and ask them about it?

image

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 19, 2024
@bclozel
Copy link
Member

bclozel commented Dec 19, 2024

Thanks for trying; I'll see what I can do.
In the meantime, if your contribution matches what the https://developercertificate.org/ says, you can force push your commit and signoff on it with git commit --signoff.

…to describe what parts that are removed from the template

Signed-off-by: Mattias-Sehlstedt <[email protected]>
@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the docs-uri-observability-metric branch from 07bc906 to 7ea938b Compare December 19, 2024 11:10
@pivotal-cla
Copy link

@Mattias-Sehlstedt Thank you for signing the Contributor License Agreement!

@bclozel bclozel removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Jan 7, 2025
@bclozel bclozel added this to the 6.2.2 milestone Jan 7, 2025
@bclozel bclozel closed this in 50b1fb0 Jan 7, 2025
@bclozel
Copy link
Member

bclozel commented Jan 7, 2025

Thanks @Mattias-Sehlstedt for your contribution!
FYI we're moving away from the CLA and using signoffs now so this should avoid such problems in the future.

@Mattias-Sehlstedt Mattias-Sehlstedt deleted the docs-uri-observability-metric branch January 7, 2025 11:37
@Mattias-Sehlstedt
Copy link
Contributor Author

Thanks for the quick feedback and assistance @bclozel, makes it a very pleasant experience to contribute to open source 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear documentation for the uri observability metric in HTTP clients
4 participants