Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary semicolons in enum declarations #32069

Closed
wants to merge 1 commit into from

Conversation

mnhock
Copy link
Contributor

@mnhock mnhock commented Jan 20, 2024

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 20, 2024
snicoll

This comment was marked as outdated.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jan 20, 2024
@sbrannen
Copy link
Member

Thanks for the PR.

Unfortunately we don't have a policy stating that we remove semicolons in enum declarations.

In light of that, I am closing this PR.

@sbrannen sbrannen closed this Jan 20, 2024
@sbrannen sbrannen added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 20, 2024
@sbrannen sbrannen changed the title Remove unnecessary semicolons Remove unnecessary semicolons in enum declarations Jan 21, 2024
sbrannen pushed a commit that referenced this pull request Jan 21, 2024
sbrannen added a commit that referenced this pull request Jan 21, 2024
@sbrannen sbrannen added type: task A general task and removed status: declined A suggestion or change that we don't feel we should currently apply labels Jan 21, 2024
@sbrannen sbrannen self-assigned this Jan 21, 2024
@sbrannen sbrannen added this to the 6.1.4 milestone Jan 21, 2024
@sbrannen
Copy link
Member

sbrannen commented Jan 21, 2024

Hi @mnhock,

Traditionally we had a mix of enum constant declarations with and without the closing semicolon; however, apparently all of the unnecessary semicolons have been removed over the years except the last four that you updated in this PR.

In light of that, I decided to merge your PR (see a8fa98e and 5856d2e) in order to achieve consistency across the code base, and we'll consider making it an official policy in our Code Style.

Cheers,

Sam

@mnhock
Copy link
Contributor Author

mnhock commented Jan 21, 2024

Hi @sbrannen!

Thanks for merging the PR and providing clarity on the consistency across the code base. I appreciate your attention to this and the effort to maintain a unified coding style.

Thanks to the awesome Spring Team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants