Skip to content

Resolve default value when argument converts to null #30636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Nheyll
Copy link
Contributor

@Nheyll Nheyll commented Jun 11, 2023

Resolves #29550
I just added a condition that checks if the argument is converted to null after being resolved a first time. If it does and it has a default value, the default value is resolved.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 11, 2023
@quaff
Copy link
Contributor

quaff commented Jun 12, 2023

You should add a test case.

@Nheyll Nheyll force-pushed the whitespace-default-value branch from c8f14f2 to e8c3551 Compare June 14, 2023 20:00
@Nheyll
Copy link
Contributor Author

Nheyll commented Jun 14, 2023

You should add a test case.

Just pushed my test case thanks for the advice

@Nheyll Nheyll force-pushed the whitespace-default-value branch from e8c3551 to 2919c23 Compare June 14, 2023 20:12
@izeye
Copy link
Contributor

izeye commented Jul 7, 2023

#29550 that this PR seems to try to resolve has been resolved in b98c1ec already.

@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jul 11, 2023
@rstoyanchev
Copy link
Contributor

Indeed, #29950 has been addressed already in M1 and this is a duplicate.

@rstoyanchev rstoyanchev added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space in integer request parameter neither triggers the default value nor generates a 400
6 participants