Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to spring-asciidoctor-backends #29162

Closed
wants to merge 1 commit into from
Closed

Switch to spring-asciidoctor-backends #29162

wants to merge 1 commit into from

Conversation

Buzzardo
Copy link
Contributor

to get the new look and feel and new functionality. A side effect is a simpler docs.gradle file.

Switch to spring-asciidoctor-backends
a23d4c4 
to get the new look and feel and new functionality.
A side effect is a simpler docs.gradle file.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 15, 2022
@sbrannen sbrannen added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 16, 2022
@sbrannen sbrannen added this to the 6.0.0-RC1 milestone Sep 16, 2022
@sbrannen
Copy link
Member

Thanks for the PR, @Buzzardo!

We'll give it a try before 6.0 RC1 to make sure that no links within or into the documentation are broken before merging.

@sbrannen
Copy link
Member

@Buzzardo, are you aware of any potential changes to links, anchors, etc.?

Did you perform any such testing before and after switching the backend?

@bclozel bclozel closed this in 2bf8eeb Sep 19, 2022
@bclozel bclozel self-assigned this Sep 19, 2022
@bclozel
Copy link
Member

bclozel commented Sep 19, 2022

Thanks @Buzzardo !
I've checked that resources are generated in the same place as before, code snippets are rendered properly (including the Java/Kotlin variant selectors), anchors are not broken and internal links are still working.

@bclozel
Copy link
Member

bclozel commented Sep 19, 2022

Reopening as several things are broken after the deploy.

@bclozel bclozel reopened this Sep 19, 2022
bclozel added a commit that referenced this pull request Sep 19, 2022
@bclozel
Remove extra asciidoctor configuration
3e41d7f 
See gh-29162
@bclozel
Copy link
Member

bclozel commented Sep 19, 2022

Closed with 3e41d7f

@bclozel bclozel closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bclozel bclozel

Labels
type: documentation A documentation task
Projects
None yet
Milestone
6.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@Buzzardo @sbrannen @bclozel @spring-projects-issues