Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime hints predicates after GraalVM changes #34239

Closed
bclozel opened this issue Jan 10, 2025 · 0 comments
Closed

Update runtime hints predicates after GraalVM changes #34239

bclozel opened this issue Jan 10, 2025 · 0 comments
Assignees
@bclozel
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
7.0.0-M1

Comments

@bclozel
Copy link
Member

bclozel commented Jan 10, 2025

As of #33847, method and field introspection is included by default when a type is registered.
Many methods in ReflectionHintsPredicates are now mostly useless as their default behavior checks for introspection.

We should deprecate those methods and promote instead invocation variants. For example onMethod() -> onMethodInvocation. During the upgrade, developers should remove that predicate check if it's only checking for introspection as checking for the type is enough. If they were checking for invocation, they should use the new method.
@bclozel bclozel added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jan 10, 2025
@bclozel bclozel added this to the 7.0.0-M1 milestone Jan 10, 2025
@bclozel bclozel self-assigned this Jan 10, 2025
@bclozel bclozel changed the title Update runtime hints predicates after GraalVM Update runtime hints predicates after GraalVM changes Jan 13, 2025
bclozel added a commit that referenced this issue Jan 14, 2025
@bclozel
Polishing RuntimeHintsPredicates deprecations
c022516 
This commit also deprecates the types returned by deprecated methods as
they will be removed as well in the future.

See gh-34239
bclozel added a commit that referenced this issue Jan 21, 2025
@bclozel
Fix hints and predicates for Field reflective access
f85752a 
This commit revisits the arrangement for Field hints after changes made
in gh-34239.

Closes gh-34294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

No branches or pull requests
1 participant
@bclozel